All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Tomas Winkler <tomas.winkler@intel.com>,
	Andy Whitcroft <apw@canonical.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] checkpatch: don't complain about BIT macro in uapi
Date: Tue, 19 Jul 2016 14:53:17 -0700	[thread overview]
Message-ID: <1468965197.1900.78.camel@perches.com> (raw)
In-Reply-To: <1468707033-16173-1-git-send-email-tomas.winkler@intel.com>

On Sun, 2016-07-17 at 01:10 +0300, Tomas Winkler wrote:
> BIT macro cannot be exported to UAPI, don't complain about it
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

Acked-by: Joe Perches <joe@perches.com>


Andrew, can you please pick this up?
> ---
> V2: fix indentation
>  scripts/checkpatch.pl | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a0e511206f24..76d3fccb82f3 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -5733,8 +5733,9 @@ sub process {
>  			}
>  		}
>  
> -# check for #defines like: 1 <<  that could be BIT(digit)
> -		if ($line =~ /#\s*define\s+\w+\s+\(?\s*1\s*([ulUL]*)\s*\<\<\s*(?:\d+|$Ident)\s*\)?/) {
> +# check for #defines like: 1 <<  that could be BIT(digit), it is not exported to uapi
> +		if ($realfile !~ m@^include/uapi/@ &&
> +		    $line =~ /#\s*define\s+\w+\s+\(?\s*1\s*([ulUL]*)\s*\<\<\s*(?:\d+|$Ident)\s*\)?/) {
>  			my $ull = "";
>  			$ull = "_ULL" if (defined($1) && $1 =~ /ll/i);
>  			if (CHK("BIT_MACRO",

      reply	other threads:[~2016-07-19 21:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-16 22:10 [PATCH v2] checkpatch: don't complain about BIT macro in uapi Tomas Winkler
2016-07-19 21:53 ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468965197.1900.78.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.