All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Marcel Apfelbaum <marcel@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V2] hw/virtio-pci: fix virtio behaviour on modern (PCIe) machines
Date: Wed, 20 Jul 2016 11:43:06 +0200	[thread overview]
Message-ID: <1469007786.3363.56.camel@redhat.com> (raw)
In-Reply-To: <578F3DD8.8050804@redhat.com>

  Hi,

> >> I guess we could just set VIRTIO_PCI_FLAG_DISABLE_LEGACY, avoid clearing it.
> >
> > I think we should simply drop the flags and use bool variables instead.
> >
> 
> You mean OnOffAuto new fields, right?
> We would need a wrapper since "auto" mode is not an actual value.
> But is doable, of course.

I was thinking about new variables, set to true for "on", false for
"off", and whatever we want do by default for "auto".

But moving that evaluation to small wrapper functions and just call them
when needed (which shouldn't be that often) instead of storing the
evaluation result in variables is fine too.

cheers,
  Gerd

  reply	other threads:[~2016-07-20  9:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-19 18:42 [Qemu-devel] [PATCH V2] hw/virtio-pci: fix virtio behaviour on modern (PCIe) machines Marcel Apfelbaum
2016-07-19 22:56 ` Michael S. Tsirkin
2016-07-20  8:27   ` Marcel Apfelbaum
2016-07-20  8:41   ` Gerd Hoffmann
2016-07-20  9:01     ` Marcel Apfelbaum
2016-07-20  9:43       ` Gerd Hoffmann [this message]
2016-07-20  9:16 ` Cornelia Huck
2016-07-20  9:37   ` Marcel Apfelbaum
2016-07-20 11:23     ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469007786.3363.56.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.