diff for duplicates of <1469010283.2800.5.camel@gmail.com> diff --git a/a/1.txt b/N1/1.txt index ba60d10..6d7dd87 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -28,3 +28,9 @@ Sorry, I completely missed the MIGRATE_CMA bits. Could you clarify if you caught this in testing/review? Balbir Singh. + +-- +To unsubscribe, send a message with 'unsubscribe linux-mm' in +the body to majordomo@kvack.org. For more info on Linux MM, +see: http://www.linux-mm.org/ . +Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N1/content_digest index ee647c6..965ac4f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\0fc3c7f68-bd2e-cb06-c47c-d97c520fc08b@redhat.com\0" "ref\0CAGXu5j+nHpHcYT8FyHNe6AFQCdakoSMW=UWDatyxhRK7CB7_=g@mail.gmail.com\0" "From\0Balbir Singh <bsingharora@gmail.com>\0" - "Subject\0[kernel-hardening] Re: [PATCH v3 02/11] mm: Hardened usercopy\0" + "Subject\0Re: [PATCH v3 02/11] mm: Hardened usercopy\0" "Date\0Wed, 20 Jul 2016 20:24:43 +1000\0" "To\0Kees Cook <keescook@chromium.org>" " Laura Abbott <labbott@redhat.com>\0" @@ -30,19 +30,7 @@ Joonsoo Kim <iamjoonsoo.kim@lge.com> Andrew Morton <akpm@linux-foundation.org> Andy Lutomirski <luto@kernel.org> - Borislav Petkov <bp@suse.de> - Mathias Krause <minipli@googlemail.com> - Jan Kara <jack@suse.cz> - Vitaly Wool <vitalywool@gmail.com> - Andrea Arcangeli <aarcange@redhat.com> - Dmitry Vyukov <dvyukov@google.com> - linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> - linux-ia64@vger.kernel.org - linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> - sparclinux <sparclinux@vger.kernel.org> - linux-arch <linux-arch@vger.kernel.org> - Linux-MM <linux-mm@kvack.org> - " kernel-hardening@lists.openwall.com <kernel-hardening@lists.openwall.com>\0" + " Bori\0" "\00:1\0" "b\0" "On Tue, 2016-07-19 at 11:48 -0700, Kees Cook wrote:\n" @@ -74,6 +62,12 @@ "Sorry, I completely missed the MIGRATE_CMA bits. Could you clarify if you\n" "caught this in testing/review?\n" "\n" - Balbir Singh. + "Balbir Singh.\n" + "\n" + "--\n" + "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "the body to majordomo@kvack.org. For more info on Linux MM,\n" + "see: http://www.linux-mm.org/ .\n" + "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -f153231064ce8d025f369a53acf51ca17faecea5376173bff816b6bc1994db65 +9eff31665fdd6a170dba1e77575ee124a5e7b3fb0bb24bac887282cad957d7d0
diff --git a/a/content_digest b/N2/content_digest index ee647c6..00e1de0 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,7 +3,7 @@ "ref\0fc3c7f68-bd2e-cb06-c47c-d97c520fc08b@redhat.com\0" "ref\0CAGXu5j+nHpHcYT8FyHNe6AFQCdakoSMW=UWDatyxhRK7CB7_=g@mail.gmail.com\0" "From\0Balbir Singh <bsingharora@gmail.com>\0" - "Subject\0[kernel-hardening] Re: [PATCH v3 02/11] mm: Hardened usercopy\0" + "Subject\0Re: [PATCH v3 02/11] mm: Hardened usercopy\0" "Date\0Wed, 20 Jul 2016 20:24:43 +1000\0" "To\0Kees Cook <keescook@chromium.org>" " Laura Abbott <labbott@redhat.com>\0" @@ -76,4 +76,4 @@ "\n" Balbir Singh. -f153231064ce8d025f369a53acf51ca17faecea5376173bff816b6bc1994db65 +648656624b60f719b0ae05e294532579978186f271d03eaf82779045cac3bfdb
diff --git a/a/content_digest b/N3/content_digest index ee647c6..ace3990 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -3,8 +3,8 @@ "ref\0fc3c7f68-bd2e-cb06-c47c-d97c520fc08b@redhat.com\0" "ref\0CAGXu5j+nHpHcYT8FyHNe6AFQCdakoSMW=UWDatyxhRK7CB7_=g@mail.gmail.com\0" "From\0Balbir Singh <bsingharora@gmail.com>\0" - "Subject\0[kernel-hardening] Re: [PATCH v3 02/11] mm: Hardened usercopy\0" - "Date\0Wed, 20 Jul 2016 20:24:43 +1000\0" + "Subject\0Re: [PATCH v3 02/11] mm: Hardened usercopy\0" + "Date\0Wed, 20 Jul 2016 10:24:43 +0000\0" "To\0Kees Cook <keescook@chromium.org>" " Laura Abbott <labbott@redhat.com>\0" "Cc\0LKML <linux-kernel@vger.kernel.org>" @@ -76,4 +76,4 @@ "\n" Balbir Singh. -f153231064ce8d025f369a53acf51ca17faecea5376173bff816b6bc1994db65 +f2ba615a262d3979fee3c76fbaa4cfbe631c6028fcced420d346f538f4bd7e1a
diff --git a/a/1.txt b/N4/1.txt index ba60d10..b997b76 100644 --- a/a/1.txt +++ b/N4/1.txt @@ -1,29 +1,29 @@ On Tue, 2016-07-19 at 11:48 -0700, Kees Cook wrote: > On Mon, Jul 18, 2016 at 6:06 PM, Laura Abbott <labbott@redhat.com> wrote: -> > +> >? > > On 07/15/2016 02:44 PM, Kees Cook wrote: -> > +> >? > > This doesn't work when copying CMA allocated memory since CMA purposely > > allocates larger than a page block size without setting head pages. > > Given CMA may be used with drivers doing zero copy buffers, I think it > > should be permitted. -> > +> >? > > Something like the following lets it pass (I can clean up and submit > > the is_migrate_cma_page APIs as a separate patch for review) > Yeah, this would be great. I'd rather use an accessor to check this > than a direct check for MIGRATE_CMA. > -> > */ -> > for (; ptr <= end ; ptr += PAGE_SIZE, page = virt_to_head_page(ptr)) +> > ?????????*/ +> > ????????for (; ptr <= end ; ptr += PAGE_SIZE, page = virt_to_head_page(ptr)) > > { -> > - if (!PageReserved(page)) -> > + if (!PageReserved(page) && !is_migrate_cma_page(page)) -> > return "<spans multiple pages>"; -> > } +> > -???????????????if (!PageReserved(page)) +> > +???????????????if (!PageReserved(page) && !is_migrate_cma_page(page)) +> > ????????????????????????return "<spans multiple pages>"; +> > ????????} > Yeah, I'll modify this a bit so that which type it starts as is > maintained for all pages (rather than allowing to flip back and forth > -- even though that is likely impossible). -> +>? Sorry, I completely missed the MIGRATE_CMA bits. Could you clarify if you caught this in testing/review? diff --git a/a/content_digest b/N4/content_digest index ee647c6..4333f4c 100644 --- a/a/content_digest +++ b/N4/content_digest @@ -2,78 +2,41 @@ "ref\01468619065-3222-3-git-send-email-keescook@chromium.org\0" "ref\0fc3c7f68-bd2e-cb06-c47c-d97c520fc08b@redhat.com\0" "ref\0CAGXu5j+nHpHcYT8FyHNe6AFQCdakoSMW=UWDatyxhRK7CB7_=g@mail.gmail.com\0" - "From\0Balbir Singh <bsingharora@gmail.com>\0" - "Subject\0[kernel-hardening] Re: [PATCH v3 02/11] mm: Hardened usercopy\0" + "From\0bsingharora@gmail.com (Balbir Singh)\0" + "Subject\0[PATCH v3 02/11] mm: Hardened usercopy\0" "Date\0Wed, 20 Jul 2016 20:24:43 +1000\0" - "To\0Kees Cook <keescook@chromium.org>" - " Laura Abbott <labbott@redhat.com>\0" - "Cc\0LKML <linux-kernel@vger.kernel.org>" - Daniel Micay <danielmicay@gmail.com> - Josh Poimboeuf <jpoimboe@redhat.com> - Rik van Riel <riel@redhat.com> - Casey Schaufler <casey@schaufler-ca.com> - PaX Team <pageexec@freemail.hu> - Brad Spengler <spender@grsecurity.net> - Russell King <linux@armlinux.org.uk> - Catalin Marinas <catalin.marinas@arm.com> - Will Deacon <will.deacon@arm.com> - Ard Biesheuvel <ard.biesheuvel@linaro.org> - Benjamin Herrenschmidt <benh@kernel.crashing.org> - Michael Ellerman <mpe@ellerman.id.au> - Tony Luck <tony.luck@intel.com> - Fenghua Yu <fenghua.yu@intel.com> - David S. Miller <davem@davemloft.net> - x86@kernel.org <x86@kernel.org> - Christoph Lameter <cl@linux.com> - Pekka Enberg <penberg@kernel.org> - David Rientjes <rientjes@google.com> - Joonsoo Kim <iamjoonsoo.kim@lge.com> - Andrew Morton <akpm@linux-foundation.org> - Andy Lutomirski <luto@kernel.org> - Borislav Petkov <bp@suse.de> - Mathias Krause <minipli@googlemail.com> - Jan Kara <jack@suse.cz> - Vitaly Wool <vitalywool@gmail.com> - Andrea Arcangeli <aarcange@redhat.com> - Dmitry Vyukov <dvyukov@google.com> - linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> - linux-ia64@vger.kernel.org - linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> - sparclinux <sparclinux@vger.kernel.org> - linux-arch <linux-arch@vger.kernel.org> - Linux-MM <linux-mm@kvack.org> - " kernel-hardening@lists.openwall.com <kernel-hardening@lists.openwall.com>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Tue, 2016-07-19 at 11:48 -0700, Kees Cook wrote:\n" "> On Mon, Jul 18, 2016 at 6:06 PM, Laura Abbott <labbott@redhat.com> wrote:\n" - "> >\302\240\n" + "> >?\n" "> > On 07/15/2016 02:44 PM, Kees Cook wrote:\n" - "> >\302\240\n" + "> >?\n" "> > This doesn't work when copying CMA allocated memory since CMA purposely\n" "> > allocates larger than a page block size without setting head pages.\n" "> > Given CMA may be used with drivers doing zero copy buffers, I think it\n" "> > should be permitted.\n" - "> >\302\240\n" + "> >?\n" "> > Something like the following lets it pass (I can clean up and submit\n" "> > the is_migrate_cma_page APIs as a separate patch for review)\n" "> Yeah, this would be great. I'd rather use an accessor to check this\n" "> than a direct check for MIGRATE_CMA.\n" ">\n" - "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240*/\n" - "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240for (; ptr <= end ; ptr += PAGE_SIZE, page = virt_to_head_page(ptr))\n" + "> > ?????????*/\n" + "> > ????????for (; ptr <= end ; ptr += PAGE_SIZE, page = virt_to_head_page(ptr))\n" "> > {\n" - "> > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (!PageReserved(page))\n" - "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (!PageReserved(page) && !is_migrate_cma_page(page))\n" - "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240return \"<spans multiple pages>\";\n" - "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240}\n" + "> > -???????????????if (!PageReserved(page))\n" + "> > +???????????????if (!PageReserved(page) && !is_migrate_cma_page(page))\n" + "> > ????????????????????????return \"<spans multiple pages>\";\n" + "> > ????????}\n" "> Yeah, I'll modify this a bit so that which type it starts as is\n" "> maintained for all pages (rather than allowing to flip back and forth\n" "> -- even though that is likely impossible).\n" - ">\302\240\n" + ">?\n" "Sorry, I completely missed the MIGRATE_CMA bits. Could you clarify if you\n" "caught this in testing/review?\n" "\n" Balbir Singh. -f153231064ce8d025f369a53acf51ca17faecea5376173bff816b6bc1994db65 +ee3362ff8946a0a0316376fee6d291ee4e03ec7781b821ebcfb7532fbf48511e
diff --git a/a/1.txt b/N5/1.txt index ba60d10..a651abd 100644 --- a/a/1.txt +++ b/N5/1.txt @@ -1,30 +1,36 @@ On Tue, 2016-07-19 at 11:48 -0700, Kees Cook wrote: > On Mon, Jul 18, 2016 at 6:06 PM, Laura Abbott <labbott@redhat.com> wrote: -> > +> >A > > On 07/15/2016 02:44 PM, Kees Cook wrote: -> > +> >A > > This doesn't work when copying CMA allocated memory since CMA purposely > > allocates larger than a page block size without setting head pages. > > Given CMA may be used with drivers doing zero copy buffers, I think it > > should be permitted. -> > +> >A > > Something like the following lets it pass (I can clean up and submit > > the is_migrate_cma_page APIs as a separate patch for review) > Yeah, this would be great. I'd rather use an accessor to check this > than a direct check for MIGRATE_CMA. > -> > */ -> > for (; ptr <= end ; ptr += PAGE_SIZE, page = virt_to_head_page(ptr)) +> > A A A A A A A A A */ +> > A A A A A A A A for (; ptr <= end ; ptr += PAGE_SIZE, page = virt_to_head_page(ptr)) > > { -> > - if (!PageReserved(page)) -> > + if (!PageReserved(page) && !is_migrate_cma_page(page)) -> > return "<spans multiple pages>"; -> > } +> > -A A A A A A A A A A A A A A A if (!PageReserved(page)) +> > +A A A A A A A A A A A A A A A if (!PageReserved(page) && !is_migrate_cma_page(page)) +> > A A A A A A A A A A A A A A A A A A A A A A A A return "<spans multiple pages>"; +> > A A A A A A A A } > Yeah, I'll modify this a bit so that which type it starts as is > maintained for all pages (rather than allowing to flip back and forth > -- even though that is likely impossible). -> +>A Sorry, I completely missed the MIGRATE_CMA bits. Could you clarify if you caught this in testing/review? Balbir Singh. + +-- +To unsubscribe, send a message with 'unsubscribe linux-mm' in +the body to majordomo@kvack.org. For more info on Linux MM, +see: http://www.linux-mm.org/ . +Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N5/content_digest index ee647c6..9c82b31 100644 --- a/a/content_digest +++ b/N5/content_digest @@ -3,7 +3,7 @@ "ref\0fc3c7f68-bd2e-cb06-c47c-d97c520fc08b@redhat.com\0" "ref\0CAGXu5j+nHpHcYT8FyHNe6AFQCdakoSMW=UWDatyxhRK7CB7_=g@mail.gmail.com\0" "From\0Balbir Singh <bsingharora@gmail.com>\0" - "Subject\0[kernel-hardening] Re: [PATCH v3 02/11] mm: Hardened usercopy\0" + "Subject\0Re: [PATCH v3 02/11] mm: Hardened usercopy\0" "Date\0Wed, 20 Jul 2016 20:24:43 +1000\0" "To\0Kees Cook <keescook@chromium.org>" " Laura Abbott <labbott@redhat.com>\0" @@ -47,33 +47,39 @@ "b\0" "On Tue, 2016-07-19 at 11:48 -0700, Kees Cook wrote:\n" "> On Mon, Jul 18, 2016 at 6:06 PM, Laura Abbott <labbott@redhat.com> wrote:\n" - "> >\302\240\n" + "> >A \n" "> > On 07/15/2016 02:44 PM, Kees Cook wrote:\n" - "> >\302\240\n" + "> >A \n" "> > This doesn't work when copying CMA allocated memory since CMA purposely\n" "> > allocates larger than a page block size without setting head pages.\n" "> > Given CMA may be used with drivers doing zero copy buffers, I think it\n" "> > should be permitted.\n" - "> >\302\240\n" + "> >A \n" "> > Something like the following lets it pass (I can clean up and submit\n" "> > the is_migrate_cma_page APIs as a separate patch for review)\n" "> Yeah, this would be great. I'd rather use an accessor to check this\n" "> than a direct check for MIGRATE_CMA.\n" ">\n" - "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240*/\n" - "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240for (; ptr <= end ; ptr += PAGE_SIZE, page = virt_to_head_page(ptr))\n" + "> > A A A A A A A A A */\n" + "> > A A A A A A A A for (; ptr <= end ; ptr += PAGE_SIZE, page = virt_to_head_page(ptr))\n" "> > {\n" - "> > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (!PageReserved(page))\n" - "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (!PageReserved(page) && !is_migrate_cma_page(page))\n" - "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240return \"<spans multiple pages>\";\n" - "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240}\n" + "> > -A A A A A A A A A A A A A A A if (!PageReserved(page))\n" + "> > +A A A A A A A A A A A A A A A if (!PageReserved(page) && !is_migrate_cma_page(page))\n" + "> > A A A A A A A A A A A A A A A A A A A A A A A A return \"<spans multiple pages>\";\n" + "> > A A A A A A A A }\n" "> Yeah, I'll modify this a bit so that which type it starts as is\n" "> maintained for all pages (rather than allowing to flip back and forth\n" "> -- even though that is likely impossible).\n" - ">\302\240\n" + ">A \n" "Sorry, I completely missed the MIGRATE_CMA bits. Could you clarify if you\n" "caught this in testing/review?\n" "\n" - Balbir Singh. + "Balbir Singh.\n" + "\n" + "--\n" + "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "the body to majordomo@kvack.org. For more info on Linux MM,\n" + "see: http://www.linux-mm.org/ .\n" + "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -f153231064ce8d025f369a53acf51ca17faecea5376173bff816b6bc1994db65 +b48cae4a4bf5555b68ac7c815f9c4d04effcdd672e8f67a75b10091d9901a5d7
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.