diff for duplicates of <1469097692-103146-3-git-send-email-benoit@wsystem.com> diff --git a/a/1.txt b/N1/1.txt index daa9897..6f2d4a2 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,10 +1,10 @@ The Weekday register is encoded as 2^tm_wday, with tm_wday in 0..6, so -using tm_wday =3D ffs(reg) to fill tm_wday from the register value is +using tm_wday = ffs(reg) to fill tm_wday from the register value is wrong because this gives the expected value + 1. This could be fixed as -tm_wday =3D ffs(reg) - 1, but tm_wday =3D ilog2(reg) works as well and is +tm_wday = ffs(reg) - 1, but tm_wday = ilog2(reg) works as well and is more direct. -Signed-off-by: Beno=C3=AEt Th=C3=A9baudeau <benoit@wsystem.com> +Signed-off-by: Benoît Thébaudeau <benoit@wsystem.com> --- drivers/rtc/rtc-rv8803.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) @@ -14,34 +14,21 @@ index e740c83..aa1d6b6 100644 --- a/drivers/rtc/rtc-rv8803.c +++ b/drivers/rtc/rtc-rv8803.c @@ -13,6 +13,7 @@ -=20 + #include <linux/bcd.h> #include <linux/bitops.h> +#include <linux/log2.h> #include <linux/i2c.h> #include <linux/interrupt.h> #include <linux/kernel.h> -@@ -145,7 +146,7 @@ static int rv8803_get_time(struct device *dev, struct r= -tc_time *tm) - tm->tm_sec =3D bcd2bin(date[RV8803_SEC] & 0x7f); - tm->tm_min =3D bcd2bin(date[RV8803_MIN] & 0x7f); - tm->tm_hour =3D bcd2bin(date[RV8803_HOUR] & 0x3f); -- tm->tm_wday =3D ffs(date[RV8803_WEEK] & 0x7f); -+ tm->tm_wday =3D ilog2(date[RV8803_WEEK] & 0x7f); - tm->tm_mday =3D bcd2bin(date[RV8803_DAY] & 0x3f); - tm->tm_mon =3D bcd2bin(date[RV8803_MONTH] & 0x1f) - 1; - tm->tm_year =3D bcd2bin(date[RV8803_YEAR]) + 100; ---=20 +@@ -145,7 +146,7 @@ static int rv8803_get_time(struct device *dev, struct rtc_time *tm) + tm->tm_sec = bcd2bin(date[RV8803_SEC] & 0x7f); + tm->tm_min = bcd2bin(date[RV8803_MIN] & 0x7f); + tm->tm_hour = bcd2bin(date[RV8803_HOUR] & 0x3f); +- tm->tm_wday = ffs(date[RV8803_WEEK] & 0x7f); ++ tm->tm_wday = ilog2(date[RV8803_WEEK] & 0x7f); + tm->tm_mday = bcd2bin(date[RV8803_DAY] & 0x3f); + tm->tm_mon = bcd2bin(date[RV8803_MONTH] & 0x1f) - 1; + tm->tm_year = bcd2bin(date[RV8803_YEAR]) + 100; +-- 2.5.0 - ---=20 -You received this message because you are subscribed to "rtc-linux". -Membership options at http://groups.google.com/group/rtc-linux . -Please read http://groups.google.com/group/rtc-linux/web/checklist -before submitting a driver. ----=20 -You received this message because you are subscribed to the Google Groups "= -rtc-linux" group. -To unsubscribe from this group and stop receiving emails from it, send an e= -mail to rtc-linux+unsubscribe@googlegroups.com. -For more options, visit https://groups.google.com/d/optout. diff --git a/a/content_digest b/N1/content_digest index 5415d87..27b40ff 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ "ref\01469097692-103146-1-git-send-email-benoit@wsystem.com\0" "From\0Beno\303\256t Th\303\251baudeau <benoit@wsystem.com>\0" - "Subject\0[rtc-linux] [PATCH 3/6] rtc: rv8803: Fix read day of week\0" + "Subject\0[PATCH 3/6] rtc: rv8803: Fix read day of week\0" "Date\0Thu, 21 Jul 2016 12:41:29 +0200\0" "To\0rtc-linux@googlegroups.com\0" "Cc\0linux-kernel@vger.kernel.org" @@ -10,12 +10,12 @@ "\00:1\0" "b\0" "The Weekday register is encoded as 2^tm_wday, with tm_wday in 0..6, so\n" - "using tm_wday =3D ffs(reg) to fill tm_wday from the register value is\n" + "using tm_wday = ffs(reg) to fill tm_wday from the register value is\n" "wrong because this gives the expected value + 1. This could be fixed as\n" - "tm_wday =3D ffs(reg) - 1, but tm_wday =3D ilog2(reg) works as well and is\n" + "tm_wday = ffs(reg) - 1, but tm_wday = ilog2(reg) works as well and is\n" "more direct.\n" "\n" - "Signed-off-by: Beno=C3=AEt Th=C3=A9baudeau <benoit@wsystem.com>\n" + "Signed-off-by: Beno\303\256t Th\303\251baudeau <benoit@wsystem.com>\n" "---\n" " drivers/rtc/rtc-rv8803.c | 3 ++-\n" " 1 file changed, 2 insertions(+), 1 deletion(-)\n" @@ -25,36 +25,23 @@ "--- a/drivers/rtc/rtc-rv8803.c\n" "+++ b/drivers/rtc/rtc-rv8803.c\n" "@@ -13,6 +13,7 @@\n" - "=20\n" + " \n" " #include <linux/bcd.h>\n" " #include <linux/bitops.h>\n" "+#include <linux/log2.h>\n" " #include <linux/i2c.h>\n" " #include <linux/interrupt.h>\n" " #include <linux/kernel.h>\n" - "@@ -145,7 +146,7 @@ static int rv8803_get_time(struct device *dev, struct r=\n" - "tc_time *tm)\n" - " \ttm->tm_sec =3D bcd2bin(date[RV8803_SEC] & 0x7f);\n" - " \ttm->tm_min =3D bcd2bin(date[RV8803_MIN] & 0x7f);\n" - " \ttm->tm_hour =3D bcd2bin(date[RV8803_HOUR] & 0x3f);\n" - "-\ttm->tm_wday =3D ffs(date[RV8803_WEEK] & 0x7f);\n" - "+\ttm->tm_wday =3D ilog2(date[RV8803_WEEK] & 0x7f);\n" - " \ttm->tm_mday =3D bcd2bin(date[RV8803_DAY] & 0x3f);\n" - " \ttm->tm_mon =3D bcd2bin(date[RV8803_MONTH] & 0x1f) - 1;\n" - " \ttm->tm_year =3D bcd2bin(date[RV8803_YEAR]) + 100;\n" - "--=20\n" - "2.5.0\n" - "\n" - "--=20\n" - "You received this message because you are subscribed to \"rtc-linux\".\n" - "Membership options at http://groups.google.com/group/rtc-linux .\n" - "Please read http://groups.google.com/group/rtc-linux/web/checklist\n" - "before submitting a driver.\n" - "---=20\n" - "You received this message because you are subscribed to the Google Groups \"=\n" - "rtc-linux\" group.\n" - "To unsubscribe from this group and stop receiving emails from it, send an e=\n" - "mail to rtc-linux+unsubscribe@googlegroups.com.\n" - For more options, visit https://groups.google.com/d/optout. + "@@ -145,7 +146,7 @@ static int rv8803_get_time(struct device *dev, struct rtc_time *tm)\n" + " \ttm->tm_sec = bcd2bin(date[RV8803_SEC] & 0x7f);\n" + " \ttm->tm_min = bcd2bin(date[RV8803_MIN] & 0x7f);\n" + " \ttm->tm_hour = bcd2bin(date[RV8803_HOUR] & 0x3f);\n" + "-\ttm->tm_wday = ffs(date[RV8803_WEEK] & 0x7f);\n" + "+\ttm->tm_wday = ilog2(date[RV8803_WEEK] & 0x7f);\n" + " \ttm->tm_mday = bcd2bin(date[RV8803_DAY] & 0x3f);\n" + " \ttm->tm_mon = bcd2bin(date[RV8803_MONTH] & 0x1f) - 1;\n" + " \ttm->tm_year = bcd2bin(date[RV8803_YEAR]) + 100;\n" + "-- \n" + 2.5.0 -99398732150573a8b092db3546b718b61513d8b9e1cc3c662df6010b1ce24040 +48baf0d1b9fb52d872fe334062e39caf2e41f50a69502b4b4ef73747eb2eeaa0
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.