From: Gerd Hoffmann <kraxel@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Marcel Apfelbaum <marcel@redhat.com>,
qemu-devel@nongnu.org, cornelia.huck@de.ibm.com
Subject: Re: [Qemu-devel] [PATCH V3] hw/virtio-pci: fix virtio behaviour
Date: Thu, 21 Jul 2016 23:58:52 +0200 [thread overview]
Message-ID: <1469138332.3363.66.camel@redhat.com> (raw)
In-Reply-To: <20160722003618-mutt-send-email-mst@kernel.org>
Hi,
> Actually this can still break existing scripts:
> stick a device on express bus but add disable-modern=on
> Gave you a legacy device previously but it no longer does.
Unlikely to happen in practice because there is little reason to use
disable-modern=on in 2.6 & older because that is the default ...
Still we can default to legacy=yes in case disable-modern=on +
disable-legacy=auto. And throw and error in case both modern and legacy
are explicitly disabled (as already suggested elsewhere in this thread).
cheers,
Gerd
next prev parent reply other threads:[~2016-07-21 21:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 15:28 [Qemu-devel] [PATCH V3] hw/virtio-pci: fix virtio behaviour Marcel Apfelbaum
2016-07-21 5:43 ` Marcel Apfelbaum
2016-07-21 6:35 ` Gerd Hoffmann
2016-07-21 8:54 ` Cornelia Huck
2016-07-21 9:26 ` Marcel Apfelbaum
2016-07-21 11:03 ` Cornelia Huck
2016-07-21 20:18 ` Michael S. Tsirkin
2016-07-22 7:44 ` Marcel Apfelbaum
2016-07-21 21:37 ` Michael S. Tsirkin
2016-07-21 21:58 ` Gerd Hoffmann [this message]
2016-07-21 22:21 ` Michael S. Tsirkin
2016-07-22 7:55 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469138332.3363.66.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.