Re: [xen-unstable test] 97737: regressions - FAIL

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1717 bytes --]

On Fri, 2016-07-22 at 11:49 +0100, Wei Liu wrote:
> On Fri, Jul 22, 2016 at 03:27:30AM +0000, osstest service owner
> wrote:
> > 
> > flight 97737 xen-unstable real [real]
> > http://logs.test-lab.xenproject.org/osstest/logs/97737/
> > 
> > Regressions :-(
> > 
> > Tests which did not succeed and are blocking,
> > including tests which could not be run:
> >  test-amd64-amd64-xl-credit2  19 guest-start/debian.repeat fail
> > REGR. vs. 97664
> >  test-armhf-armhf-xl          15 guest-start/debian.repeat fail
> > REGR. vs. 97664
> >  test-armhf-armhf-xl-credit2  15 guest-start/debian.repeat fail
> > REGR. vs. 97664
>
Thanks from bringing my attention to this. I've seen it happening in
local testing a few times also, and was investigating already.

> From
> http://logs.test-lab.xenproject.org/osstest/logs/97737/test-amd64-amd
> 64-xl-credit2/serial-fiano0.log
> 
> Jul 21 07:38:22.383917 (XEN) Assertion 'rqd->avgload >= 0 && rqd-
> >b_avgload >= 0' failed at sched_credit2.c:734
>
Right. My investigation shows that it is the b_avgload>=0 check that is
actually failing, and looking at the code confirmed that, and I found
out why.

I've just sent a patch that I believe will fix this.

I can't find it in the archives yet, but it should be:
 [PATCH] xen: credit2: don't let b_avgload go negative.
 msg-id: <146918909364.19443.6394900696027710502.stgit@Solace.fritz.box>

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel