All of lore.kernel.org
 help / color / mirror / Atom feed
From: <gregkh@linuxfoundation.org>
To: tiwai@suse.de, dan.carpenter@oracle.com, gregkh@linuxfoundation.org
Cc: <stable@vger.kernel.org>, <stable-commits@vger.kernel.org>
Subject: Patch "ALSA: au88x0: Fix calculation in vortex_wtdma_bufshift()" has been added to the 4.6-stable tree
Date: Sun, 24 Jul 2016 17:30:52 -0700	[thread overview]
Message-ID: <14694066527816@kroah.com> (raw)


This is a note to let you know that I've just added the patch titled

    ALSA: au88x0: Fix calculation in vortex_wtdma_bufshift()

to the 4.6-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     alsa-au88x0-fix-calculation-in-vortex_wtdma_bufshift.patch
and it can be found in the queue-4.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 62db7152c924e4c060e42b34a69cd39658e8a0dc Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai@suse.de>
Date: Wed, 29 Jun 2016 15:23:08 +0200
Subject: ALSA: au88x0: Fix calculation in vortex_wtdma_bufshift()

From: Takashi Iwai <tiwai@suse.de>

commit 62db7152c924e4c060e42b34a69cd39658e8a0dc upstream.

vortex_wtdma_bufshift() function does calculate the page index
wrongly, first masking then shift, which always results in zero.
The proper computation is to first shift, then mask.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 sound/pci/au88x0/au88x0_core.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

--- a/sound/pci/au88x0/au88x0_core.c
+++ b/sound/pci/au88x0/au88x0_core.c
@@ -1444,9 +1444,8 @@ static int vortex_wtdma_bufshift(vortex_
 	int page, p, pp, delta, i;
 
 	page =
-	    (hwread(vortex->mmio, VORTEX_WTDMA_STAT + (wtdma << 2)) &
-	     WT_SUBBUF_MASK)
-	    >> WT_SUBBUF_SHIFT;
+	    (hwread(vortex->mmio, VORTEX_WTDMA_STAT + (wtdma << 2))
+	     >> WT_SUBBUF_SHIFT) & WT_SUBBUF_MASK;
 	if (dma->nr_periods >= 4)
 		delta = (page - dma->period_real) & 3;
 	else {


Patches currently in stable-queue which might be from tiwai@suse.de are

queue-4.6/alsa-hda-fix-the-headset-mic-jack-detection-on-dell-machine.patch
queue-4.6/alsa-ctl-stop-notification-after-disconnection.patch
queue-4.6/alsa-dummy-fix-a-use-after-free-at-closing.patch
queue-4.6/alsa-timer-fix-negative-queue-usage-by-racy-accesses.patch
queue-4.6/alsa-hda-fix-use-after-free-after-module-unload.patch
queue-4.6/alsa-hda-realtek-add-new-pin-definition-in-alc225-pin-quirk-table.patch
queue-4.6/alsa-hdac_regmap-fix-the-register-access-for-runtime-pm.patch
queue-4.6/alsa-hda-add-pci-id-for-kabylake-h.patch
queue-4.6/alsa-usb-audio-fix-quirks-code-is-not-called.patch
queue-4.6/alsa-pcm-free-chmap-at-pcm-free-callback-too.patch
queue-4.6/alsa-au88x0-fix-calculation-in-vortex_wtdma_bufshift.patch
queue-4.6/alsa-hda-realtek-add-lenovo-l460-to-docking-unit-fixup.patch
queue-4.6/alsa-echoaudio-fix-memory-allocation.patch
queue-4.6/alsa-hda-realtek-add-two-more-thinkpad-ids-5050-5053-for-tpt460-fixup.patch
queue-4.6/alsa-hda-fix-read-before-array-start.patch
queue-4.6/alsa-hda-add-amd-stoney-pci-id-with-proper-driver-caps.patch

                 reply	other threads:[~2016-07-25  0:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14694066527816@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=stable-commits@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.