From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <mpe@ellerman.id.au>,
Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/3] powerpc/mm: Rename hpte_init_lpar() & put fallback in a header
Date: Mon, 25 Jul 2016 22:11:28 +1000 [thread overview]
Message-ID: <1469448688.5978.47.camel@kernel.crashing.org> (raw)
In-Reply-To: <87r3aidmxv.fsf@concordia.ellerman.id.au>
On Mon, 2016-07-25 at 20:36 +1000, Michael Ellerman wrote:
> That would be nice, but these look fishy at least:
>
> arch/powerpc/platforms/cell/spu_manage.c: if (!firmware_has_feature(FW_FEATURE_LPAR))
> arch/powerpc/platforms/cell/spu_manage.c: if (!firmware_has_feature(FW_FEATURE_LPAR)) {
> > arch/powerpc/platforms/cell/spu_manage.c: if (!firmware_has_feature(FW_FEATURE_LPAR))
Those can just be checks for LV1, I think ..
> > arch/powerpc/platforms/pasemi/iommu.c: !firmware_has_feature(FW_FEATURE_LPAR)) {
> drivers/net/ethernet/pasemi/pasemi_mac.c: return firmware_has_feature(FW_FEATURE_LPAR);
And that was some experiemtal PAPR'ish thing wasn't it ?
Cheers,
Ben.
next prev parent reply other threads:[~2016-07-25 12:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 2:57 [PATCH 1/3] powerpc/mm: Fix build break due when PPC_NATIVE=n Michael Ellerman
2016-07-25 2:57 ` [PATCH 2/3] powerpc/mm: Rename hpte_init_lpar() & put fallback in a header Michael Ellerman
2016-07-25 4:13 ` Stephen Rothwell
2016-07-25 4:42 ` Benjamin Herrenschmidt
2016-07-25 5:33 ` Michael Ellerman
2016-07-25 9:49 ` Benjamin Herrenschmidt
2016-07-25 10:36 ` Michael Ellerman
2016-07-25 12:11 ` Benjamin Herrenschmidt [this message]
2016-07-27 0:27 ` Michael Ellerman
2016-07-25 2:57 ` [PATCH 3/3] powerpc/mm: Drop unused externs for hpte_init_beat[_v3]() Michael Ellerman
2016-07-27 14:32 ` [3/3] " Michael Ellerman
2016-07-25 4:03 ` [PATCH 1/3] powerpc/mm: Fix build break due when PPC_NATIVE=n Stephen Rothwell
2016-07-25 6:17 ` Michael Ellerman
2016-07-25 10:39 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469448688.5978.47.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.