From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40344)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1bRoQn-0001o1-QE
	for qemu-devel@nongnu.org; Mon, 25 Jul 2016 18:33:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1bRoQi-0000R6-LR
	for qemu-devel@nongnu.org; Mon, 25 Jul 2016 18:33:00 -0400
Message-ID: <1469483433.5978.59.camel@kernel.crashing.org>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Tue, 26 Jul 2016 07:50:33 +1000
In-Reply-To: <F9EA185B-897B-47A5-A52F-C6DF2417F111@adacore.com>
References: <1469439886.5978.31.camel@kernel.crashing.org>
	<F9EA185B-897B-47A5-A52F-C6DF2417F111@adacore.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] ppc: TCG and FP exceptions, is it right ?
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tristan Gingold <gingold@adacore.com>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, David Gibson <david@gibson.dropbear.id.au>, Paul Mackerras <pmac@au1.ibm.com>, Anton Blanchard <anton@au1.ibm.com>, Fabien Chouteau <chouteau@adacore.com>, Richard Henderson <rth@twiddle.net>

On Mon, 2016-07-25 at 17:12 +0200, Tristan Gingold wrote:
> >=20
> > The code as writte will take the exception before the FPR is
> > updated,
> > I *think*, or am I missing something here=C2=A0=C2=A0?
>=20
> This looks like an oversight. In our tests, we don't read the fpr.

BTW. Do you happen to have some tests I could run to verify that my
changes don't break your code ?

Cheers,
Ben.