From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSFsx-0006WV-9M for qemu-devel@nongnu.org; Tue, 26 Jul 2016 23:51:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSFsr-0005rf-AA for qemu-devel@nongnu.org; Tue, 26 Jul 2016 23:51:54 -0400 Message-ID: <1469591501.5978.103.camel@kernel.crashing.org> From: Benjamin Herrenschmidt Date: Wed, 27 Jul 2016 13:51:41 +1000 In-Reply-To: <20160727020443.GT17429@voom.fritz.box> References: <1469571686-7284-1-git-send-email-benh@kernel.crashing.org> <1469571686-7284-13-git-send-email-benh@kernel.crashing.org> <20160727020443.GT17429@voom.fritz.box> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 13/32] ppc: Don't update NIP in lswi/lswx/stswi/stswx List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On Wed, 2016-07-27 at 12:04 +1000, David Gibson wrote: > On Wed, Jul 27, 2016 at 08:21:07AM +1000, Benjamin Herrenschmidt > wrote: > > Instead, pass GETPC() result to the corresponding helpers. This > > requires a bit of fiddling to get the PC (hopefully) right in > > the case where we generate a program check, though the hacks there > > are temporary, a subsequent patch will clean this all up by always > > having the nip already set to the right instruction when taking > > the fault. >=20 > Where are cpu_ldub_data() and cpu_ldub_data_ra() defined?=C2=A0 I assum= e > it's via macro somewhere, since I couldn't find it with a grep. Yeah all that stuff is defined via macros in include/exec/cpu_ldst.h and cpu_ldst_template.h