diff for duplicates of <1469729529.3998.59.camel@perches.com> diff --git a/a/1.txt b/N1/1.txt index 09e382f..7494ce2 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -6,30 +6,30 @@ On Wed, 2016-07-27 at 23:46 -0400, Theodore Ts'o wrote: > > > > It causes this allocation failure and subsequent crash on s390 with fake > > NUMA enabled -> Thanks for reporting this. This patch fixes things for you, yes? +> Thanks for reporting this. This patch fixes things for you, yes? trivia: > diff --git a/drivers/char/random.c b/drivers/char/random.c [] > @@ -1668,13 +1668,12 @@ static int rand_initialize(void) -> #ifdef CONFIG_NUMA -> pool = kmalloc(num_nodes * sizeof(void *), -> GFP_KERNEL|__GFP_NOFAIL|__GFP_ZERO); +> #ifdef CONFIG_NUMA +> pool = kmalloc(num_nodes * sizeof(void *), +> GFP_KERNEL|__GFP_NOFAIL|__GFP_ZERO); The __GFP_ZERO is unusual and this could use kcalloc instead. > - for (i=0; i < num_nodes; i++) { > + for_each_online_node(i) { -> crng = kmalloc_node(sizeof(struct crng_state), -> GFP_KERNEL | __GFP_NOFAIL, i); -> spin_lock_init(&crng->lock); -> crng_initialize(crng); -> pool[i] = crng; +> crng = kmalloc_node(sizeof(struct crng_state), +> GFP_KERNEL | __GFP_NOFAIL, i); +> spin_lock_init(&crng->lock); +> crng_initialize(crng); +> pool[i] = crng; > - -> } -> mb(); -> crng_node_pool = pool; +> } +> mb(); +> crng_node_pool = pool; -- To unsubscribe, send a message with 'unsubscribe linux-mm' in diff --git a/a/content_digest b/N1/content_digest index cb092ea..aaa4bde 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -19,30 +19,30 @@ "> > \n" "> > It causes this allocation failure and subsequent crash on s390 with fake\n" "> > NUMA enabled\n" - "> Thanks for reporting this.\302\240\302\240This patch fixes things for you, yes?\n" + "> Thanks for reporting this. This patch fixes things for you, yes?\n" "\n" "trivia:\n" "\n" "> diff --git a/drivers/char/random.c b/drivers/char/random.c\n" "[]\n" "> @@ -1668,13 +1668,12 @@ static int rand_initialize(void)\n" - "> \302\240#ifdef CONFIG_NUMA\n" - "> \302\240\tpool = kmalloc(num_nodes * sizeof(void *),\n" - "> \302\240\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\240GFP_KERNEL|__GFP_NOFAIL|__GFP_ZERO);\n" + "> #ifdef CONFIG_NUMA\n" + "> \tpool = kmalloc(num_nodes * sizeof(void *),\n" + "> \t\t GFP_KERNEL|__GFP_NOFAIL|__GFP_ZERO);\n" "\n" "The __GFP_ZERO is unusual and this could use kcalloc instead.\n" "\n" "> -\tfor (i=0; i < num_nodes; i++) {\n" "> +\tfor_each_online_node(i) {\n" - "> \302\240\t\tcrng = kmalloc_node(sizeof(struct crng_state),\n" - "> \302\240\t\t\t\t\302\240\302\240\302\240\302\240GFP_KERNEL | __GFP_NOFAIL, i);\n" - "> \302\240\t\tspin_lock_init(&crng->lock);\n" - "> \302\240\t\tcrng_initialize(crng);\n" - "> \302\240\t\tpool[i] = crng;\n" + "> \t\tcrng = kmalloc_node(sizeof(struct crng_state),\n" + "> \t\t\t\t GFP_KERNEL | __GFP_NOFAIL, i);\n" + "> \t\tspin_lock_init(&crng->lock);\n" + "> \t\tcrng_initialize(crng);\n" + "> \t\tpool[i] = crng;\n" "> -\n" - "> \302\240\t}\n" - "> \302\240\tmb();\n" - "> \302\240\tcrng_node_pool = pool;\n" + "> \t}\n" + "> \tmb();\n" + "> \tcrng_node_pool = pool;\n" "\n" "--\n" "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" @@ -50,4 +50,4 @@ "see: http://www.linux-mm.org/ .\n" "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -6c7a2a47454454c61041d2bcb5529fa4fe8a4d2669903d6ff45042c4a3b126fb +9a2f01abdf536834dd90f17cd10c06234c7e0cb9e5740e07a9c16d9d269eb6e1
diff --git a/a/1.txt b/N2/1.txt index 09e382f..1ac4129 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -30,9 +30,3 @@ The __GFP_ZERO is unusual and this could use kcalloc instead. > } > mb(); > crng_node_pool = pool; - --- -To unsubscribe, send a message with 'unsubscribe linux-mm' in -the body to majordomo@kvack.org. For more info on Linux MM, -see: http://www.linux-mm.org/ . -Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N2/content_digest index cb092ea..efa006c 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -42,12 +42,6 @@ "> -\n" "> \302\240\t}\n" "> \302\240\tmb();\n" - "> \302\240\tcrng_node_pool = pool;\n" - "\n" - "--\n" - "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" - "the body to majordomo@kvack.org. For more info on Linux MM,\n" - "see: http://www.linux-mm.org/ .\n" - "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" + "> \302\240\tcrng_node_pool = pool;" -6c7a2a47454454c61041d2bcb5529fa4fe8a4d2669903d6ff45042c4a3b126fb +42fed65b22e4bdc57870eac8233a417ebbb5a6a60cd64fcbbe2c82cbe1abd113
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.