All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
To: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"Auld, Matthew" <matthew.auld@intel.com>
Subject: Re: [PATCH] drm/i915: remove redundant fbc warnings
Date: Thu, 28 Jul 2016 18:29:58 +0000	[thread overview]
Message-ID: <1469730595.2800.3.camel@intel.com> (raw)
In-Reply-To: <1467710914-15146-1-git-send-email-matthew.auld@intel.com>

Em Ter, 2016-07-05 às 10:28 +0100, Matthew Auld escreveu:
> The fbc enabled/active sanity checks are already done in
> __intel_fbc_disable so no need to do them again.
> 
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_fbc.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_fbc.c
> b/drivers/gpu/drm/i915/intel_fbc.c
> index 067b6f5..e77104d 100644
> --- a/drivers/gpu/drm/i915/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/intel_fbc.c
> @@ -1163,11 +1163,8 @@ void intel_fbc_disable(struct intel_crtc
> *crtc)
>  		return;
>  
>  	mutex_lock(&fbc->lock);
> -	if (fbc->crtc == crtc) {
> -		WARN_ON(!fbc->enabled);
> -		WARN_ON(fbc->active);
> +	if (fbc->crtc == crtc)
>  		__intel_fbc_disable(dev_priv);
> -	}
>  	mutex_unlock(&fbc->lock);
>  
>  	cancel_work_sync(&fbc->work.work);
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2016-07-28 18:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-05  9:28 [PATCH] drm/i915: remove redundant fbc warnings Matthew Auld
2016-07-05 10:21 ` ✗ Ro.CI.BAT: failure for " Patchwork
2016-08-02 11:05   ` Matthew Auld
2016-08-02 11:27     ` Joonas Lahtinen
2016-07-28 18:29 ` Zanoni, Paulo R [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469730595.2800.3.camel@intel.com \
    --to=paulo.r.zanoni@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.