From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Ed Bartosh <ed.bartosh@linux.intel.com>,
openembedded-core@lists.openembedded.org,
Patrick Ohly <patrick.ohly@intel.com>
Subject: Re: [PATCH v4 1/4] image.bbclass: fix dependency calculation when using conversion chaining
Date: Thu, 28 Jul 2016 21:51:12 +0100 [thread overview]
Message-ID: <1469739072.9142.19.camel@linuxfoundation.org> (raw)
In-Reply-To: <0dacdf96b1ac7c9c2bcd0071a0b8d88fcc6231d5.1469623667.git.ed.bartosh@linux.intel.com>
On Wed, 2016-07-27 at 15:51 +0300, Ed Bartosh wrote:
> From: Patrick Ohly <patrick.ohly@intel.com>
>
> When using conversion chaining (for example example: .dsk.vdi.xz),
> the imagetypes_getdepends() did not properly detect all compression
> commands (thus skipping the corresponding COMPRESS_DEPENDS) and
> the base type, leading to missing dependencies of the image's
> do_rootfs
> task.
>
> This is not a big problem in practice because in those cases where
> conversion chaining is useful (as in the example above), the missing
> dependency is qemu-native, which typically gets built anyway.
>
> imagetypes_getdepends() had hard-coded special treatment for certain
> image types. This gets replaced with setting the normal IMAGE_DEPENDS
> variables for these types.
Also, where is this hardcoding? I can't see it in the patch.
Perhaps http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=b567235c0c
e427e2cd478a0268a295c74208e917 fixed this already?
Just makes me all the more suspicious of this patch...
Cheers,
Richard
next prev parent reply other threads:[~2016-07-28 20:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 12:51 [PATCH v4 0/4] image creation improvements Ed Bartosh
2016-07-27 12:51 ` [PATCH v4 1/4] image.bbclass: fix dependency calculation when using conversion chaining Ed Bartosh
2016-07-28 20:42 ` Richard Purdie
2016-07-29 8:22 ` Ed Bartosh
2016-07-28 20:51 ` Richard Purdie [this message]
2016-07-27 12:51 ` [PATCH v4 2/4] image creation: support converting masked types Ed Bartosh
2016-07-27 12:51 ` [PATCH v4 3/4] image.bbclass: rename COMPRESS(ION) to CONVERSION Ed Bartosh
2016-07-27 12:51 ` [PATCH v4 4/4] image.bbclass: prefer specialized image creation methods over chaining Ed Bartosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469739072.9142.19.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=ed.bartosh@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=patrick.ohly@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.