All of lore.kernel.org
 help / color / mirror / Atom feed
From: james_p_freyensee@linux.intel.com (J Freyensee)
Subject: [PATCH] nvme-cli: user-defined hostnqn option for discover
Date: Thu, 28 Jul 2016 14:21:54 -0700	[thread overview]
Message-ID: <1469740914.9209.3.camel@linux.intel.com> (raw)
In-Reply-To: <20160728203534.GB2420@localhost.localdomain>

On Thu, 2016-07-28@16:35 -0400, Keith Busch wrote:
> On Thu, Jul 28, 2016@11:20:15PM +0300, Roy Shterman wrote:
> > Hi Jay,
> > 
> > Actually I planned to send the same patch tomorrow,
> > 
> > I think we should add user-defined hostnqn parameter into 'connect'
> > command.
> 
> Is it okay to apply this as-is, or should I wait for the patch for
> connect?

I think we should break up the patches as one for discover, and one for
connect.  Each patch can show a usage for each of the commands (one for
'discover', one for 'connect'.

How about apply my discover patch as-is, then Roy re-submit his patch
for connect?  And in the connect patch, supply an example usage (which
I think this will be useful as there is currently no man pages for
these new fabrics commands).


> 
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2016-07-28 21:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-28 20:03 [PATCH] *** Discovery feature fix in nvme-cli *** Jay Freyensee
2016-07-28 20:03 ` [PATCH] nvme-cli: user-defined hostnqn option for discover Jay Freyensee
2016-07-28 20:20   ` Roy Shterman
2016-07-28 20:35     ` Keith Busch
2016-07-28 21:21       ` J Freyensee [this message]
     [not found]         ` <45CF57A8-206F-4353-9386-A0BB8158AB5A@mellanox.com>
2016-07-28 21:36           ` [PATCH] [RESEND] " J Freyensee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469740914.9209.3.camel@linux.intel.com \
    --to=james_p_freyensee@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.