All of lore.kernel.org
 help / color / mirror / Atom feed
From: Beth 'pidge' Flanagan <pidge@toganlabs.com>
To: "Aníbal Limón" <anibal.limon@linux.intel.com>, yocto@yoctoproject.org
Cc: joshua.g.lock@intel.com, pidge@togenlabs.com
Subject: Re: [PATCH][yocto-autobuilder] lib/buildsteps.py: fix report creation in nigthly-oecore
Date: Fri, 29 Jul 2016 17:31:30 +0200	[thread overview]
Message-ID: <1469806290.3657.0.camel@toganlabs.com> (raw)
In-Reply-To: <1469805026-22041-1-git-send-email-anibal.limon@linux.intel.com>

On Fri, 2016-07-29 at 10:10 -0500, Aníbal Limón wrote:
> nightly-oecore buildset doesn't prove got_revision property
> so when got_revision is None use got_revision_oecore instead.
> 
> [YOCTO #10051]
> 
> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
> ---
>  lib/python2.7/site-packages/autobuilder/lib/buildsteps.py | 7 +++++-
> -
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/python2.7/site-
> packages/autobuilder/lib/buildsteps.py b/lib/python2.7/site-
> packages/autobuilder/lib/buildsteps.py
> index eee0c1b..37ac8b0 100644
> --- a/lib/python2.7/site-packages/autobuilder/lib/buildsteps.py
> +++ b/lib/python2.7/site-packages/autobuilder/lib/buildsteps.py
> @@ -118,8 +118,11 @@ class BitbakeShellCommand(ShellCommand):
>          report['target_sys'] = vrs['TARGET_SYS']
>  
>          report['component'] = 'bitbake'
> -        report['branch_commit'] = self.getProperty('branch') + ': '
> + \
> -                self.getProperty('got_revision')
> +        branch = self.getProperty('branch')
> +        revision = self.getProperty('got_revision')
> +        if not revision:
> +            revision = self.getProperty('got_revision_oecore')
> +        report['branch_commit'] = branch + ': ' + revision
> 

I'd put this in a try except. What happens with eclipse?

-b

>  
>          failure = {}
>          failure['package'] = "bitbake-%s" % vrs['BB_VERSION']
> -- 
> 2.1.4
> 


  parent reply	other threads:[~2016-07-29 15:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-29 15:10 [PATCH][yocto-autobuilder] lib/buildsteps.py: fix report creation in nigthly-oecore Aníbal Limón
2016-07-29 15:19 ` Aníbal Limón
2016-07-29 15:31 ` Beth 'pidge' Flanagan [this message]
2016-07-29 15:47   ` Aníbal Limón
2016-07-29 15:50     ` Beth 'pidge' Flanagan
2016-07-29 15:58       ` Aníbal Limón

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469806290.3657.0.camel@toganlabs.com \
    --to=pidge@toganlabs.com \
    --cc=anibal.limon@linux.intel.com \
    --cc=joshua.g.lock@intel.com \
    --cc=pidge@togenlabs.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.