All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nadim almas <nadim.902@gmail.com>
To: abbotti@mev.co.uk
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	devel@driverdev.osuosl.org, Nadim almas <nadim.902@gmail.com>
Subject: [PATCH 34/34] Staging: comedi: drivers: cd_pcidas: Compression of
Date: Sat, 30 Jul 2016 13:04:55 -0700	[thread overview]
Message-ID: <1469909095-15991-1-git-send-email-nadim.902@gmail.com> (raw)

This patch compresses two lines in to a single line in file
cb_pcidas.c
if immediate return statement is found. It also removes variable
bytes_written as it is no longer needed.

It is done using script Coccinelle. And coccinelle uses following
semantic patch for this compression function:

@@
expression e, ret;
@@

-ret =
+return
     e;
-return ret

Signed-off-by: Nadim Almas <nadim.902@gmail.com>
---
 
 drivers/staging/comedi/drivers/cb_pcidas64.c | 4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)


 
diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
index 1f9c08a..d30cf3d 100644
--- a/drivers/staging/comedi/drivers/cb_pcidas64.c
+++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
@@ -1408,9 +1408,7 @@ static int set_ai_fifo_size(struct comedi_device *dev, unsigned int num_samples)
 	if (retval < 0)
 		return retval;
 
-	num_samples = retval * fifo->num_segments * fifo->sample_packing_ratio;
-
-	return num_samples;
+	return retval * fifo->num_segments * fifo->sample_packing_ratio;
 }
 
 /* query length of fifo */
-- 
2.7.4

             reply	other threads:[~2016-07-30 20:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-30 20:04 Nadim almas [this message]
2016-08-02 17:42 ` [PATCH 34/34] Staging: comedi: drivers: cd_pcidas: Compression of Ian Abbott
2016-08-21 14:57 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469909095-15991-1-git-send-email-nadim.902@gmail.com \
    --to=nadim.902@gmail.com \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.