From: Gerd Hoffmann <kraxel@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, Colin Lord <clord@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for 2.8 3/3] sdl: Modularize
Date: Mon, 01 Aug 2016 13:53:57 +0200 [thread overview]
Message-ID: <1470052437.30562.39.camel@redhat.com> (raw)
In-Reply-To: <1469600777-30413-4-git-send-email-famz@redhat.com>
On Mi, 2016-07-27 at 14:26 +0800, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
more verbose commit message please, especially for those (like me) who
have not worked yet with modules.
Will sdl be loaded unconditionally?
Or only with -display sdl?
What happens if the module is not present?
The main benefit I see in modularizing the ui is that we can move the ui
modules (and the UI libs dependency chain) to a separate rpm subpackage,
can we start that with this series applied?
Can modules have dependencies on other modules? When it comes to
modularizing spice we will need that as qxl has a spice dependency ...
cheers,
Gerd
next prev parent reply other threads:[~2016-08-01 11:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 6:26 [Qemu-devel] [PATCH for 2.8 0/3] Modularize SDL Fam Zheng
2016-07-27 6:26 ` [Qemu-devel] [PATCH for 2.8 1/3] rules.mak: Don't extract libs from .mo-libs in link command Fam Zheng
2016-08-01 10:24 ` Paolo Bonzini
2016-07-27 6:26 ` [Qemu-devel] [PATCH for 2.8 2/3] configure: Add CONFIG_SDL2 Fam Zheng
2016-07-27 6:26 ` [Qemu-devel] [PATCH for 2.8 3/3] sdl: Modularize Fam Zheng
2016-07-27 23:23 ` Colin Lord
2016-07-28 5:17 ` Fam Zheng
2016-07-28 7:43 ` Fam Zheng
2016-08-01 10:33 ` Paolo Bonzini
2016-08-01 10:31 ` Paolo Bonzini
2016-08-02 1:28 ` Fam Zheng
2016-08-01 10:39 ` Daniel P. Berrange
2016-08-01 11:53 ` Gerd Hoffmann [this message]
2016-08-02 1:22 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470052437.30562.39.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=clord@redhat.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.