From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michal Sojka <sojkam1@fel.cvut.cz>
Cc: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@lists.ozlabs.org
Subject: Re: MPC5200 does not boot
Date: Tue, 02 Aug 2016 12:44:33 +1000 [thread overview]
Message-ID: <1470105873.12584.7.camel@kernel.crashing.org> (raw)
In-Reply-To: <874m74w1m7.fsf@steelpick.2x.cz>
On Tue, 2016-08-02 at 00:44 +0200, Michal Sojka wrote:
> Hi Benjamin,
>
> the following commit causes my MPC5200 not to boot.
>
> commit 9402c684613163888714df0955fa1f17142b08bf
> > Author: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Date: Tue Jul 5 15:03:41 2016 +1000
>
> powerpc: Factor do_feature_fixup calls
>
> 32 and 64-bit do a similar set of calls early on, we move it all to
> a single common function to make the boot code more readable.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>
> I suspect that the cause will be similar as described in commit
> 1cd03890ea64795e53f17a94928cca22495acb2a. Unfortunately, I don't have
> much time to debug this, but I can easily test patches.
Are you sure of your bisection ? Did you verify that reverting that one
patch fixes it ? Because all this does is move code to a function,
the code is functionally the same and called in the same place...
Cheers,
Ben.
next prev parent reply other threads:[~2016-08-02 2:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 22:44 MPC5200 does not boot Michal Sojka
2016-08-02 2:44 ` Benjamin Herrenschmidt [this message]
2016-08-02 3:16 ` Nicholas Piggin
2016-08-02 3:18 ` Benjamin Herrenschmidt
2016-08-02 5:38 ` Benjamin Herrenschmidt
2016-08-02 5:47 ` Michal Sojka
2016-08-10 10:52 ` Michal Sojka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470105873.12584.7.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=sojkam1@fel.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.