From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935205AbcHBOn3 (ORCPT ); Tue, 2 Aug 2016 10:43:29 -0400 Received: from mx2.suse.de ([195.135.220.15]:55234 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964936AbcHBMnq (ORCPT ); Tue, 2 Aug 2016 08:43:46 -0400 Message-ID: <1470140595.30985.20.camel@suse.com> Subject: Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error From: Oliver Neukum To: robert.foss@collabora.com Cc: pprabhu@chromium.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Date: Tue, 02 Aug 2016 14:23:15 +0200 In-Reply-To: <1469729992-6228-1-git-send-email-robert.foss@collabora.com> References: <1469729992-6228-1-git-send-email-robert.foss@collabora.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-07-28 at 14:19 -0400, robert.foss@collabora.com wrote: > From: Prathmesh Prabhu > > Implemented queued response handling. This queue is processed every > time the > WDM_READ flag is cleared. > > In case of a read error, userspace may not actually read the data, > since the > driver returns an error through wdm_poll. After this, the underlying > device may > attempt to send us more data, but the queue is not processed. While > userspace is > also blocked, because the read error is never cleared. Could you explain why user space cannot just read more data? That will clear the error. Regards Oliver