From: Joshua G Lock <joshua.g.lock@linux.intel.com>
To: Chen Qi <Qi.Chen@windriver.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] systemd: split systemd-container
Date: Tue, 02 Aug 2016 15:55:03 +0100 [thread overview]
Message-ID: <1470149703.2984.22.camel@linux.intel.com> (raw)
In-Reply-To: <b833d4bb5bd450464c93f49727f0dd31691897a5.1468466649.git.Qi.Chen@windriver.com>
On Thu, 2016-07-14 at 11:25 +0800, Chen Qi wrote:
> Split container/vm related units into a new package, systemd-
> container.
>
> The split mainly references Fedora 24, with a few differences.
> Apart from the bash and zsh completion files, the differences include
> adding systemd-spawn@.service into the systemd-container package.
>
> [YOCTO #9835]
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
> meta/recipes-core/systemd/systemd_230.bb | 35
> +++++++++++++++++++++++++++++---
> 1 file changed, 32 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-core/systemd/systemd_230.bb b/meta/recipes-
> core/systemd/systemd_230.bb
> index 374a197..cf8aec1 100644
> --- a/meta/recipes-core/systemd/systemd_230.bb
> +++ b/meta/recipes-core/systemd/systemd_230.bb
> @@ -291,6 +291,7 @@ PACKAGES =+ "\
> ${PN}-pam \
> ${PN}-zsh-completion \
> ${PN}-xorg-xinitrc \
> + ${PN}-container \
> ${PN}-extra-utils \
> "
>
> @@ -348,6 +349,37 @@ RRECOMMENDS_${PN}-binfmt = "kernel-module-
> binfmt-misc"
>
> RRECOMMENDS_${PN}-vconsole-setup = "kbd kbd-consolefonts kbd-
> keymaps"
It would be nice to provide more information about systemd-container to
package managers with a SUMMARY_${PN}-container and DESCRIPTION_${PN}-
container
>
> +FILES_${PN}-container = "${sysconfdir}/dbus-
> 1/system.d/org.freedesktop.import1.conf \
> + ${sysconfdir}/dbus-
> 1/system.d/org.freedesktop.machine1.conf \
> + ${base_bindir}/machinectl \
> + ${bindir}/systemd-nspawn \
> + ${exec_prefix}/lib/systemd/import-
> pubring.gpg \
any reason you didn't use ${libdir}/systemd/import-pubring.gpg or
${nonarch_libdir} if the files is always installed in /usr/lib
regardless of whether libdir is i.e. /usr/lib64
> + ${systemd_unitdir}/system/busnames.target.w
> ants/org.freedesktop.import1.busname \
> + ${systemd_unitdir}/system/busnames.target.w
> ants/org.freedesktop.machine1.busname \
> + ${systemd_unitdir}/system/local-
> fs.target.wants/var-lib-machines.mount \
> + ${systemd_unitdir}/system/machine.slice \
> + ${systemd_unitdir}/system/machines.target \
> + ${systemd_unitdir}/system/org.freedesktop.i
> mport1.busname \
> + ${systemd_unitdir}/system/org.freedesktop.m
> achine1.busname \
> + ${systemd_unitdir}/system/systemd-
> importd.service \
> + ${systemd_unitdir}/system/systemd-
> machined.service \
> + ${systemd_unitdir}/system/var-lib-
> machines.mount \
I realise these are probably copy/pasted, but you could replace all of
the ${systemd_unitdir}/system with ${systemd_system_unitdir}
Otherwise this change looks good, thanks!
Joshua
> + ${rootlibexecdir}/systemd/systemd-import \
> + ${rootlibexecdir}/systemd/systemd-importd \
> + ${rootlibexecdir}/systemd/systemd-journal-
> gatewayd \
> + ${rootlibexecdir}/systemd/systemd-journal-
> remote \
> + ${rootlibexecdir}/systemd/systemd-journal-
> upload \
> + ${rootlibexecdir}/systemd/systemd-machined
> \
> + ${rootlibexecdir}/systemd/systemd-pull
> \+ ${exec_prefix}/lib/tmpfiles.d/systemd-
> nspawn.conf \
> + ${systemd_unitdir}/system/systemd-
> nspawn@.service \
> + ${libdir}/libnss_mymachines.so.2 \
> + ${datadir}/dbus-1/system-
> services/org.freedesktop.import1.service \
> + ${datadir}/dbus-1/system-
> services/org.freedesktop.machine1.service \
> + ${datadir}/polkit-
> 1/actions/org.freedesktop.import1.policy \
> + ${datadir}/polkit-
> 1/actions/org.freedesktop.machine1.policy \
> + "
> +
> FILES_${PN}-extra-utils = "\
> ${base_bindir}/systemd-escape \
> ${base_bindir}/systemd-inhibit \
> @@ -371,9 +403,6 @@ FILES_${PN}-extra-utils = "\
> ${rootlibexecdir}/systemd/systemd-resolve-
> host \
> ${rootlibexecdir}/systemd/systemd-ac-power \
> ${rootlibexecdir}/systemd/systemd-activate \
> - ${bindir}/systemd-nspawn \
> - ${exec_prefix}/lib/tmpfiles.d/systemd-
> nspawn.conf \
> - ${systemd_unitdir}/system/systemd-
> nspawn@.service \
> ${rootlibexecdir}/systemd/systemd-bus-proxyd
> \
> ${systemd_unitdir}/system/systemd-bus-
> proxyd.service \
> ${systemd_unitdir}/system/systemd-bus-
> proxyd.socket \
> --
> 1.9.1
>
next prev parent reply other threads:[~2016-08-02 14:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 3:25 [PATCH 0/1] systemd: split systemd-container Chen Qi
2016-07-14 3:25 ` [PATCH 1/1] " Chen Qi
2016-08-02 14:55 ` Joshua G Lock [this message]
2016-08-19 2:01 ` ChenQi
2016-08-02 3:10 ` [PATCH 0/1] " ChenQi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470149703.2984.22.camel@linux.intel.com \
--to=joshua.g.lock@linux.intel.com \
--cc=Qi.Chen@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.