Re: [PATCH v12 00/22] Add Hisilicon RoCE driver

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2272 bytes --]

On Thu, 2016-07-21 at 19:06 +0800, Lijun Ou wrote:
> The Hisilicon Network Substem is a long term evolution IP which is
> supposed to be used in Hisilicon ICT SoCs. HNS (Hisilicon Network
> Sybsystem) also has a hardware support of performing RDMA with
> RoCEE.
> The driver for Hisilicon RoCEE(RoCE Engine) is a platform driver and
> will support mulitple versions of SOCs in future. This version of
> driver
> is meant to support Hip06 SoC(which confirms to RoCEv1 hardware
> specifications).

I would like to thank you for being as responsive as you've been during
the review process.  I know you have put a lot of effort into
addressing people's questions/comments.  You've addressed the review
comments I had, as well as other peoples.  At this point, I don't want
to say the driver is perfect, because as you continue to look at it you
will almost always find something you can nitpick (like this segment in
hns_roce_cmd.h:

enum {
	HNS_ROCE_CMD_TIME_CLASS_A	= 10000,
	HNS_ROCE_CMD_TIME_CLASS_B	= 10000,
	HNS_ROCE_CMD_TIME_CLASS_C	= 10000,
};

This is a case where you guys used the mlx4 RoCE driver as a template
to help you create your own...and their driver has to have different
timeout expectations for different firmware commands because some take
a long time and others don't, and you ended up copying this TIME_CLASS
stuff to your driver, but it isn't really needed and so they all have
the same value).  However, I believe you have brought the driver to a
level of quality sufficient for the initial submission to the linux
tree.  As such, I have taken v12 of your patchset.  I squashed many of
the patches into just one patch, so the series now looks like this:

dd778a9920a6 MAINTAINERS: Add maintainers for Hisilicon RoCE driver
51db6bbe7de1 IB/hns: Kconfig and Makefile for RoCE module
5e43122add63 IB/hns: Add driver files for hns RoCE driver
c2c3b9d9e463 devicetree: bindings: IB: Add binding document for
Hisilicon RoCE
c80815c0b214 net: hns: Add reset function support for RoCE driver
92d21ac74a9e Linux 4.7-rc7

Thanks for all the hard work in answering review comments, series
applied ;-)

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]