All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Amitoj Kaur Chawla
	<amitoj1606-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: julia.lawall-L2FTfq7BK8M@public.gmane.org
Subject: Re: [PATCH] RDMA/cxgb3: Use AF_INET for sin_family field
Date: Tue, 02 Aug 2016 13:06:08 -0400	[thread overview]
Message-ID: <1470157568.18081.14.camel@redhat.com> (raw)
In-Reply-To: <20160704125744.GA16796@amitoj-Inspiron-3542>

[-- Attachment #1: Type: text/plain, Size: 914 bytes --]

On Mon, 2016-07-04 at 18:27 +0530, Amitoj Kaur Chawla wrote:
> Elsewhere the sin_family field holds a value with a name of the form
> AF_..., so it seems reasonable to do so here as well.  Also the
> values
> of PF_INET and AF_INET are the same.
> 
> The Coccinelle semantic patch that makes this change is as follows:
> 
> // <smpl>
> @@
> struct sockaddr_in sip;
> @@
> 
> (
> sip.sin_family ==
> - PF_INET
> + AF_INET
> > 
> > 
> sip.sin_family !=
> - PF_INET
> + AF_INET
> > 
> > 
> sip.sin_family =
> - PF_INET
> + AF_INET
> )
> // </smpl>
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  drivers/infiniband/hw/cxgb3/iwch_cm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Thanks, applied.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      reply	other threads:[~2016-08-02 17:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-04 12:57 [PATCH] RDMA/cxgb3: Use AF_INET for sin_family field Amitoj Kaur Chawla
2016-07-04 12:57 ` Amitoj Kaur Chawla
2016-08-02 17:06 ` Doug Ledford [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470157568.18081.14.camel@redhat.com \
    --to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=amitoj1606-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=julia.lawall-L2FTfq7BK8M@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.