From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [PATCH v11 4/5] powerpc/fsl: move mpc85xx.h to include/linux/fsl Date: Tue, 02 Aug 2016 16:40:43 -0500 Message-ID: <1470174043.25630.233.camel@buserror.net> References: <1468723822-30457-1-git-send-email-oss@buserror.net> <1468723822-30457-5-git-send-email-oss@buserror.net> <4016699.uYaV8nWfqC@wuerfel> <1469039508.25630.17.camel@buserror.net> <146909676646.16700.8383344640490662952@concordia> <1469119526.25630.42.camel@buserror.net> <1469579882.25630.168.camel@buserror.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Yangbo Lu , Michael Ellerman , Arnd Bergmann , Ulf Hansson Cc: "devicetree@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , Xiaobo Xie , "linux-kernel@vger.kernel.org" List-Id: linux-mmc@vger.kernel.org T24gVHVlLCAyMDE2LTA4LTAyIGF0IDA1OjU3ICswMDAwLCBZYW5nYm8gTHUgd3JvdGU6Cj4gSGkg U2NvdHQsCj4gCj4gPiAKPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4gPiBGcm9tOiBT Y290dCBXb29kIFttYWlsdG86b3NzQGJ1c2Vycm9yLm5ldF0KPiA+IFNlbnQ6IFdlZG5lc2RheSwg SnVseSAyNywgMjAxNiA4OjM4IEFNCj4gPiBUbzogWWFuZ2JvIEx1OyBNaWNoYWVsIEVsbGVybWFu OyBBcm5kIEJlcmdtYW5uOyBVbGYgSGFuc3Nvbgo+ID4gQ2M6IGxpbnV4LW1tY0B2Z2VyLmtlcm5l bC5vcmc7IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnOyBsaW51eHBwYy0KPiA+IGRldkBsaXN0 cy5vemxhYnMub3JnOyBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnCj4gPiBTdWJqZWN0OiBS ZTogW1BBVENIIHYxMSA0LzVdIHBvd2VycGMvZnNsOiBtb3ZlIG1wYzg1eHguaCB0bwo+ID4gaW5j bHVkZS9saW51eC9mc2wKPiA+IAo+ID4gT24gTW9uLCAyMDE2LTA3LTI1IGF0IDA2OjEyICswMDAw LCBZYW5nYm8gTHUgd3JvdGU6Cj4gPiA+IAo+ID4gPiBIaSBTY290dCwKPiA+ID4gCj4gPiA+IAo+ ID4gPiA+IAo+ID4gPiA+IAo+ID4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4gPiA+ ID4gRnJvbTogU2NvdHQgV29vZCBbbWFpbHRvOm9zc0BidXNlcnJvci5uZXRdCj4gPiA+ID4gU2Vu dDogRnJpZGF5LCBKdWx5IDIyLCAyMDE2IDEyOjQ1IEFNCj4gPiA+ID4gVG86IE1pY2hhZWwgRWxs ZXJtYW47IEFybmQgQmVyZ21hbm4KPiA+ID4gPiBDYzogbGludXgtbW1jQHZnZXIua2VybmVsLm9y ZzsgZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4cHBjLQo+ID4gPiA+IGRldkBsaXN0 cy5vemxhYnMub3JnOyBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnOyBZYW5nYm8gTHUKPiA+ ID4gPiBTdWJqZWN0OiBSZTogW1BBVENIIHYxMSA0LzVdIHBvd2VycGMvZnNsOiBtb3ZlIG1wYzg1 eHguaCB0bwo+ID4gPiA+IGluY2x1ZGUvbGludXgvZnNsCj4gPiA+ID4gCj4gPiA+ID4gT24gVGh1 LCAyMDE2LTA3LTIxIGF0IDIwOjI2ICsxMDAwLCBNaWNoYWVsIEVsbGVybWFuIHdyb3RlOgo+ID4g PiA+ID4gCj4gPiA+ID4gPiAKPiA+ID4gPiA+IFF1b3RpbmcgU2NvdHQgV29vZCAoMjAxNi0wNy0y MSAwNDozMTo0OCkKPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiAKPiA+ID4g PiA+ID4gT24gV2VkLCAyMDE2LTA3LTIwIGF0IDEzOjI0ICswMjAwLCBBcm5kIEJlcmdtYW5uIHdy b3RlOgo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ ID4gPiA+IE9uIFNhdHVyZGF5LCBKdWx5IDE2LCAyMDE2IDk6NTA6MjEgUE0gQ0VTVCBTY290dCBX b29kIHdyb3RlOgo+ID4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4g PiA+IAo+ID4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gPiBGcm9tOiB5YW5nYm8gbHUgPHlh bmdiby5sdUBueHAuY29tPgo+ID4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gPiBNb3ZlIG1w Yzg1eHguaCB0byBpbmNsdWRlL2xpbnV4L2ZzbCBhbmQgcmVuYW1lIGl0IHRvIHN2ci5oCj4gPiA+ ID4gPiA+ID4gPiBhcyBhIGNvbW1vbiBoZWFkZXIgZmlsZS7CoMKgVGhpcyBTVlIgbnVtYmVyc3Bh Y2UgaXMgdXNlZCBvbgo+ID4gPiA+ID4gPiA+ID4gc29tZSBBUk0gY2hpcHMgYXMgd2VsbCBhcyBQ UEMsIGFuZCBldmVuIHRvIGNoZWNrIGZvciBhIFBQQwo+ID4gPiA+ID4gPiA+ID4gU1ZSIG11bHRp LWFyY2ggZHJpdmVycyB3b3VsZCBvdGhlcndpc2UgbmVlZCB0byBpZmRlZiB0aGUKPiA+ID4gPiA+ ID4gPiA+IGhlYWRlciBpbmNsdXNpb24gYW5kIGFsbCByZWZlcmVuY2VzIHRvIHRoZSBTVlIgc3lt Ym9scy4KPiA+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogWWFu Z2JvIEx1IDx5YW5nYm8ubHVAbnhwLmNvbT4KPiA+ID4gPiA+ID4gPiA+IEFja2VkLWJ5OiBXb2xm cmFtIFNhbmcgPHdzYUB0aGUtZHJlYW1zLmRlPgo+ID4gPiA+ID4gPiA+ID4gQWNrZWQtYnk6IFN0 ZXBoZW4gQm95ZCA8c2JveWRAY29kZWF1cm9yYS5vcmc+Cj4gPiA+ID4gPiA+ID4gPiBBY2tlZC1i eTogSm9lcmcgUm9lZGVsIDxqcm9lZGVsQHN1c2UuZGU+Cj4gPiA+ID4gPiA+ID4gPiBbc2NvdHR3 b29kOiB1cGRhdGUgZGVzY3JpcHRpb25dCj4gPiA+ID4gPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBT Y290dCBXb29kIDxvc3NAYnVzZXJyb3IubmV0Pgo+ID4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ ID4gQXMgZGlzY3Vzc2VkIGJlZm9yZSwgcGxlYXNlIGRvbid0IGludHJvZHVjZSB5ZXQgYW5vdGhl ciB2ZW5kb3IKPiA+ID4gPiA+ID4gPiBzcGVjaWZpYyB3YXkgdG8gbWF0Y2ggYSBTb0MgSUQgZnJv bSBhIGRldmljZSBkcml2ZXIuCj4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gSSd2ZSBwb3N0 ZWQgYSBwYXRjaCBmb3IgYW4gZXh0ZW5zaW9uIHRvIHRoZSBzb2NfZGV2aWNlCj4gPiA+ID4gPiA+ ID4gaW5mcmFzdHJ1Y3R1cmUgdG8gYWxsb3cgY29tcGFyaW5nIHRoZSBydW5uaW5nIFNvQyB0byBh IHRhYmxlCj4gPiA+ID4gPiA+ID4gb2YgZGV2aWNlcywgdXNlIHRoYXQgaW5zdGVhZC4KPiA+ID4g PiA+ID4gQXMgSSBhc2tlZCBiZWZvcmUsIGluIHdoaWNoIHJlbGV2YW50IG1haW50YWluZXJzaGlw IGNhcGFjaXR5IGFyZQo+ID4gPiA+ID4gPiB5b3UgTkFDS2luZyB0aGlzPwo+ID4gPiA+ID4gSSds bCBuYWNrIHRoZSBwb3dlcnBjIHBhcnQgdW50aWwgeW91IGd1eXMgY2FuIGFncmVlLgo+ID4gPiA+ IE9LLCBJJ3ZlIHB1bGxlZCB0aGVzZSBwYXRjaGVzIG91dC4KPiA+ID4gPiAKPiA+ID4gPiBGb3Ig dGhlIE1NQyBpc3N1ZSBJIHN1Z2dlc3QgdXNpbmcgaWZkZWYgQ09ORklHX1BQQyBhbmQKPiA+ID4g PiBtZnNwcihTUFJOX1NWUikgbGlrZSB0aGUgY2xvY2sgZHJpdmVyIGRvZXNbMV0gYW5kIHdlIGNh biByZXZpc2l0IHRoZQo+ID4gPiA+IGlzc3VlIGlmL3doZW4gd2UgbmVlZCB0byBkbyBzb21ldGhp bmcgc2ltaWxhciBvbiBhbiBBUk0gY2hpcC4KPiA+ID4gW0x1IFlhbmdiby1CNDcwOTNdIEkgcmVt ZW1iZXJlZCB0aGF0IFVmZmUgaGFkIG9wcG9zZWQgdXMgdG8gaW50cm9kdWNlCj4gPiA+IG5vbi0g Z2VuZXJpYyBoZWFkZXIgZmlsZXMobGlrZSAnI2luY2x1ZGUgPGFzbS9tcGM4NXh4Lmg+JykgaW4g bW1jCj4gPiA+IGRyaXZlciBpbml0aWFsbHkuIFNvIEkgdGhpbmsgaXQgd2lsbCBub3QgYmUgYWNj ZXB0ZWQgdG8gdXNlIGlmZGVmCj4gPiA+IENPTkZJR19QUEMgYW5kIG1mc3ByKFNQUk5fU1ZSKS4u Lgo+ID4gPiBBbmQgdGhpcyBtZXRob2Qgc3RpbGwgY291bGRu4oCZdCBnZXQgU1ZSIG9mIEFSTSBj aGlwIG5vdy4KPiA+IFJpZ2h0LCBhcyBJIHNhaWQgd2UnbGwgaGF2ZSB0byByZXZpc2l0IHRoZSBp c3N1ZSBpZi93aGVuIHdlIGhhdmUgdGhlIHNhbWUKPiA+IHByb2JsZW0gb24gYW4gQVJNIGNoaXAu IMKgVGhhdCBhbHNvIGFwcGxpZXMgaWYgdGhlIFBQQyBpZmRlZiBpcyBzdGlsbAo+ID4gZ2V0dGlu ZyBOQUNLZWQgZnJvbSB0aGUgTU1DIHNpZGUuCj4gW0x1IFlhbmdiby1CNDcwOTNdIEl0J3Mgbm90 IGNsZWFyIGZvciBtZSBhYm91dCB5b3VyIGlkZWEgOijCoAo+IERvIHlvdSBtZWFuIHdlIGNhbiBz dGlsbCB1c2UgdGhpcyBtZXRob2QsIG9yIG5vdCA/Cj4gSSB0aGluayBVZmZlIGhhZCBvcHBvc2Vk IHRvIHVzZSBpZmRlZiBDT05GSUdfUFBDIGFuZCBtZnNwcihTUFJOX1NWUikuCj4gSXMgdGhlcmUg YW55IHNvbHV0aW9uIHRvIHJlc29sdmUgPwo+IDopCgpBcyBJIHNhaWQsIEknbSBPSyB3aXRoIHVz aW5nIHRoZSBTUFIuIMKgSXQncyB1cCB0byB5b3UgdG8gZmluZCBvdXQgd2hldGhlciBpdCdzCnN0 aWxsIHVuYWNjZXB0YWJsZSB3aXRoIHRoZSBNTUMgbWFpbnRhaW5lcnMgZ2l2ZW4gYWxsIHRoZSBk aXNjdXNzaW9uIChpdCB3b3VsZApiZSB0aGUgcXVpY2tlc3Qgd2F5IHRvIGdldCB0aGUgd29ya2Fy b3VuZCBlbmFibGVkKSwgb3IganVzdCBnbyB3aXRoIHRoZSBtZXRob2QKYmVsb3cuCgo+ID4gPiBB bnkgb3RoZXIgc3VnZ2VzdGlvbiBoZXJlPwo+ID4gVGhlIG90aGVyIG9wdGlvbiBpcyB0byB0cnkg dG8gY29tZSB1cCB3aXRoIHNvbWV0aGluZyB0aGF0IGZpdHMgaW50bwo+ID4gQXJuZCdzIGZyYW1l d29yayB3aGlsZSBhZGRyZXNzaW5nIHRoZSBjb25jZXJucyBJIHJhaXNlZC4gwqBUaGUgc29jX2lk Cj4gPiBzdHJpbmcgc2hvdWxkIGJlIHdlbGwtc3RydWN0dXJlZCB0byBhdm9pZCBtaXNtYXRjaGVz IGFuZCBjb21wYXRpYmlsaXR5Cj4gPiBwcm9ibGVtcyAoZXNwZWNpYWxseSBzaW5jZSBpdCB3b3Vs ZCBnZXQgZXhwb3NlZCB0byB1c2Vyc3BhY2UpLiDCoE1heWJlCj4gPiBzb21ldGhpbmcgbGlrZToK PiA+IAo+ID4gc3ZyOjxTVlIgbWludXMgRSBiaXQ+LHN2cmU6PGZ1bGwgU1ZSIGluY2x1ZGluZyBF IGJpdD4sbmFtZTo8c29jCj4gPiBuYW1lPixkaWU6PHNvYyBkaWUgbmFtZT4scmV2OlguWSw8dGFn MT4sPHRhZzI+LDwuLi4+LAo+IFtMdSBZYW5nYm8tQjQ3MDkzXSBUaGUgc29jX2RldmljZV9hdHRy aWJ1dCBzdHJ1Y3QgaXMgZGVmaW5lZCBhcyBiZWxvdy4KPiBzdHJ1Y3Qgc29jX2RldmljZV9hdHRy aWJ1dGUgewo+IMKgwqDCoMKgwqDCoMKgwqBjb25zdCBjaGFyICptYWNoaW5lOwo+IMKgwqDCoMKg wqDCoMKgwqBjb25zdCBjaGFyICpmYW1pbHk7Cj4gwqDCoMKgwqDCoMKgwqDCoGNvbnN0IGNoYXIg KnJldmlzaW9uOwo+IMKgwqDCoMKgwqDCoMKgwqBjb25zdCBjaGFyICpzb2NfaWQ7Cj4gfTsKPiAK PiBXZSBjYW4gcHV0IHRoZSAnbW9kZWwnIGluIHJvb3Qgbm9kZSBvZiBkdHMgYXMgbWFjaGluZSwg cHV0ICdGcmVlc2NhbGUgUW9ySVEnCj4gYXMgZmFtaWx5LAoKSSdkIGp1c3QgcHV0ICJRb3JJUSIg dG8gYXZvaWQgdGhlIHF1ZXN0aW9uIG9mIHdoZXRoZXIgdG8gdXNlICJGcmVlc2NhbGUiIG9yCiJO WFAiLgoKPiBhbmQgcHV0IHgueCBhcyByZXZpc2lvbi4gSXMgaXQgb2s/Cj4gQXMgeW91IHN1Z2dl c3RlZCwgeW91IGxpa2UgdG8gdXNlIGJlbG93IHN0cmluZyBhcyBzb2NfaWQuIEl0J3MgZWFzeSB0 byBnZXQKPiBzdnIsIGJ1dCBob3cgZG9lcyB0aGUgc29mdHdhcmUga25vdyB0aGUgbmFtZSBhbmQg ZGllLAo+IGFuZCBwdXQgdGhlbSBpbnRvIHRoaXMgc3RyaW5nID8gSXQncyBhIGxhcmdlIGNvZGUg dG8gZGVmaW5lIHRoZW0uwqAKClllcywgdGhlcmUgd291bGQgbmVlZCB0byBiZSBhIHRhYmxlIGlu IHRoZSBndXRzIGRyaXZlciBmb3IgZWFjaCBTVlIuIMKgSWYgdGhlClNWUiBpc24ndCBmb3VuZCBp biB0aGUgdGFibGUgdGhlbiB0aGUgc29jX2lkIHdvdWxkIG9ubHkgY29udGFpbiB0aGUgc3ZyOiBh bmQKc3ZyZTogZmllbGRzLgoKPiA+IAo+ID4gc3ZyOjxTVlIgbWludXMgRSBiaXQ+LHN2cmU6PGZ1 bGwgU1ZSIGluY2x1ZGluZyBFIGJpdD4sbmFtZTo8c29jCj4gPiBuYW1lPixkaWU6PHNvYyBkaWUg bmFtZT4scmV2OlguWSw8dGFnMT4sPHRhZzI+LDwuLi4+LAo+IFNob3VsZCB3ZSByZW1vdmUgcmV2 IGhlcmUgc2luY2UgdGhlcmUgaXMgYWxzbyBhIHJldmlzaW9uIG1lbWJlcj8KClllcywgSSBmb3Jn b3QgdGhlcmUgd2FzIGEgcmV2aXNpb24gZmllbGQgLS0gaXQgc2hvdWxkIGdvIHRoZXJlIG9idmlv dXNseS4KCj4gUmVnYXJkaW5nIHRoZSBndXRzX2luaXQsIHdlIHN0aWxsIGNhbGwgZ3V0c19pbml0 IGFuZCB0aGVuIG1hdGNoIHRoZSBzb2MsIG9yCj4gd2UgY2hhbmdlIHRvIHVzZSBwbGF0Zm9ybSBk cml2ZXI/Cj4gT3IgZG8geW91IGtub3cgYW55IGJldHRlciBwbGFjZSB0byBjYWxsIGd1dHNfaW5p dCB0byBpbml0aWFsaXplIG9ubHkgb25jZT8KClVzZSBhIHBsYXRmb3JtIGRyaXZlciBmb3Igbm93 LiDCoElmIHdlIGV2ZXIgbmVlZCB0byBjaGVjayBhbiBBUk0gU1ZSIGluIHRoZQpjbG9jayBkcml2 ZXIgb3Igc2ltaWxhciBwbGFjZSwgdGhlbiBBcm5kIGNhbiBleHBsYWluIHdoYXQgaGUgd2FudHMg dXMgdG8gZG8KdGhlbiA6LSkKCi1TY290dAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KTGludXhwcGMtZGV2IG1haWxpbmcgbGlzdApMaW51eHBwYy1kZXZA bGlzdHMub3psYWJzLm9yZwpodHRwczovL2xpc3RzLm96bGFicy5vcmcvbGlzdGluZm8vbGludXhw cGMtZGV2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from host.buserror.net (host.buserror.net [209.198.135.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3s3qPx20s2zDqQn for ; Wed, 3 Aug 2016 07:40:53 +1000 (AEST) Message-ID: <1470174043.25630.233.camel@buserror.net> From: Scott Wood To: Yangbo Lu , Michael Ellerman , Arnd Bergmann , Ulf Hansson Cc: "linux-mmc@vger.kernel.org" , "devicetree@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Xiaobo Xie Date: Tue, 02 Aug 2016 16:40:43 -0500 In-Reply-To: References: <1468723822-30457-1-git-send-email-oss@buserror.net> <1468723822-30457-5-git-send-email-oss@buserror.net> <4016699.uYaV8nWfqC@wuerfel> <1469039508.25630.17.camel@buserror.net> <146909676646.16700.8383344640490662952@concordia> <1469119526.25630.42.camel@buserror.net> <1469579882.25630.168.camel@buserror.net> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Subject: Re: [PATCH v11 4/5] powerpc/fsl: move mpc85xx.h to include/linux/fsl List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2016-08-02 at 05:57 +0000, Yangbo Lu wrote: > Hi Scott, > > > > > -----Original Message----- > > From: Scott Wood [mailto:oss@buserror.net] > > Sent: Wednesday, July 27, 2016 8:38 AM > > To: Yangbo Lu; Michael Ellerman; Arnd Bergmann; Ulf Hansson > > Cc: linux-mmc@vger.kernel.org; devicetree@vger.kernel.org; linuxppc- > > dev@lists.ozlabs.org; linux-kernel@vger.kernel.org > > Subject: Re: [PATCH v11 4/5] powerpc/fsl: move mpc85xx.h to > > include/linux/fsl > > > > On Mon, 2016-07-25 at 06:12 +0000, Yangbo Lu wrote: > > > > > > Hi Scott, > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > From: Scott Wood [mailto:oss@buserror.net] > > > > Sent: Friday, July 22, 2016 12:45 AM > > > > To: Michael Ellerman; Arnd Bergmann > > > > Cc: linux-mmc@vger.kernel.org; devicetree@vger.kernel.org; linuxppc- > > > > dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; Yangbo Lu > > > > Subject: Re: [PATCH v11 4/5] powerpc/fsl: move mpc85xx.h to > > > > include/linux/fsl > > > > > > > > On Thu, 2016-07-21 at 20:26 +1000, Michael Ellerman wrote: > > > > > > > > > > > > > > > Quoting Scott Wood (2016-07-21 04:31:48) > > > > > > > > > > > > > > > > > > > > > > > > On Wed, 2016-07-20 at 13:24 +0200, Arnd Bergmann wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Saturday, July 16, 2016 9:50:21 PM CEST Scott Wood wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > From: yangbo lu > > > > > > > > > > > > > > > > Move mpc85xx.h to include/linux/fsl and rename it to svr.h > > > > > > > > as a common header file.  This SVR numberspace is used on > > > > > > > > some ARM chips as well as PPC, and even to check for a PPC > > > > > > > > SVR multi-arch drivers would otherwise need to ifdef the > > > > > > > > header inclusion and all references to the SVR symbols. > > > > > > > > > > > > > > > > Signed-off-by: Yangbo Lu > > > > > > > > Acked-by: Wolfram Sang > > > > > > > > Acked-by: Stephen Boyd > > > > > > > > Acked-by: Joerg Roedel > > > > > > > > [scottwood: update description] > > > > > > > > Signed-off-by: Scott Wood > > > > > > > > > > > > > > > As discussed before, please don't introduce yet another vendor > > > > > > > specific way to match a SoC ID from a device driver. > > > > > > > > > > > > > > I've posted a patch for an extension to the soc_device > > > > > > > infrastructure to allow comparing the running SoC to a table > > > > > > > of devices, use that instead. > > > > > > As I asked before, in which relevant maintainership capacity are > > > > > > you NACKing this? > > > > > I'll nack the powerpc part until you guys can agree. > > > > OK, I've pulled these patches out. > > > > > > > > For the MMC issue I suggest using ifdef CONFIG_PPC and > > > > mfspr(SPRN_SVR) like the clock driver does[1] and we can revisit the > > > > issue if/when we need to do something similar on an ARM chip. > > > [Lu Yangbo-B47093] I remembered that Uffe had opposed us to introduce > > > non- generic header files(like '#include ') in mmc > > > driver initially. So I think it will not be accepted to use ifdef > > > CONFIG_PPC and mfspr(SPRN_SVR)... > > > And this method still couldn’t get SVR of ARM chip now. > > Right, as I said we'll have to revisit the issue if/when we have the same > > problem on an ARM chip.  That also applies if the PPC ifdef is still > > getting NACKed from the MMC side. > [Lu Yangbo-B47093] It's not clear for me about your idea :(  > Do you mean we can still use this method, or not ? > I think Uffe had opposed to use ifdef CONFIG_PPC and mfspr(SPRN_SVR). > Is there any solution to resolve ? > :) As I said, I'm OK with using the SPR.  It's up to you to find out whether it's still unacceptable with the MMC maintainers given all the discussion (it would be the quickest way to get the workaround enabled), or just go with the method below. > > > Any other suggestion here? > > The other option is to try to come up with something that fits into > > Arnd's framework while addressing the concerns I raised.  The soc_id > > string should be well-structured to avoid mismatches and compatibility > > problems (especially since it would get exposed to userspace).  Maybe > > something like: > > > > svr:,svre:,name: > name>,die:,rev:X.Y,,,<...>, > [Lu Yangbo-B47093] The soc_device_attribut struct is defined as below. > struct soc_device_attribute { >         const char *machine; >         const char *family; >         const char *revision; >         const char *soc_id; > }; > > We can put the 'model' in root node of dts as machine, put 'Freescale QorIQ' > as family, I'd just put "QorIQ" to avoid the question of whether to use "Freescale" or "NXP". > and put x.x as revision. Is it ok? > As you suggested, you like to use below string as soc_id. It's easy to get > svr, but how does the software know the name and die, > and put them into this string ? It's a large code to define them.  Yes, there would need to be a table in the guts driver for each SVR.  If the SVR isn't found in the table then the soc_id would only contain the svr: and svre: fields. > > > > svr:,svre:,name: > name>,die:,rev:X.Y,,,<...>, > Should we remove rev here since there is also a revision member? Yes, I forgot there was a revision field -- it should go there obviously. > Regarding the guts_init, we still call guts_init and then match the soc, or > we change to use platform driver? > Or do you know any better place to call guts_init to initialize only once? Use a platform driver for now.  If we ever need to check an ARM SVR in the clock driver or similar place, then Arnd can explain what he wants us to do then :-) -Scott