Re: [PATCH] IB/hfi1: Allow for non-double word multiple message sizes for user SDMA

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]

On Wed, 2016-07-27 at 21:08 -0400, ira.weiny wrote:
> The driver pads non-double word multiple message sizes but it doesn't
> account for this padding when the packet length is calculated. Also,
> the
> data length is miscalculated for message sizes less than 4 bytes due
> to
> the bit representation in LRH. And there's a check for non-double
> word
> multiple message sizes that prevents these messages from being sent.
> This patch fixes length miscalculations and enables the functionality
> to
> send non-double word multiple message sizes.
> 
> Reviewed-by: Harish Chegondi <harish.chegondi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Sebastian Sanchez <sebastian.sanchez-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 

I agree with you, I like sizeof(u32) as compared to a bare 4.  Applied.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]