From: Balbir Singh <bsingharora@gmail.com>
To: oliver <oohall@gmail.com>, "Martin Liška" <mliska@suse.cz>
Cc: Michal Hocko <mhocko@suse.cz>,
kbuild test robot <fengguang.wu@intel.com>,
kbuild-all@01.org, linux-mm@kvack.org,
Jason Baron <jbaron@akamai.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [memcg:auto-latest 238/243] include/linux/compiler-gcc.h:243:38: error: impossible constraint in 'asm'
Date: Wed, 03 Aug 2016 15:17:01 +1000 [thread overview]
Message-ID: <1470201421.5034.1.camel@gmail.com> (raw)
In-Reply-To: <CAOSf1CG1OB+tQx=u5C5RSEFydPy4Rsa04L=Cwm4PfENWJa658A@mail.gmail.com>
On Mon, 2016-08-01 at 22:41 +1000, oliver wrote:
> On Mon, Aug 1, 2016 at 9:27 PM, Martin LiA!ka <mliska@suse.cz> wrote:
> >A
> > On 08/01/2016 01:09 PM, Michal Hocko wrote:
> > >A
> > > [CC our gcc guy - I guess he has some theory for this]
> > >A
> > > On Sun 31-07-16 14:11:25, Michal Hocko wrote:
> > > >A
> > > > It seems that this has been already reported and Jason has noticed [1] that
> > > > the problem is in the disabled optimizations:
> > > >A
> > > > $ grep CRYPTO_DEV_UX500_DEBUG .config
> > > > CONFIG_CRYPTO_DEV_UX500_DEBUG=y
> > > >A
> > > > if I disable this particular option the code compiles just fine. I have
> > > > no idea what is wrong about the code but it seems to depend on
> > > > optimizations enabled which sounds a bit scrary...
> > > >A
> > > > [1] http://www.spinics.net/lists/linux-mm/msg109590.html
> > Hi.
> >A
> > The difference is that w/o any optimization level, GCC doesn't make %c0 an
> > intermediate integer operand [1] (see description of "i" constraint).
> We recently hit a similar problem on ppc where the compiler couldn't
> satisfy an "i" when it was wrapped in an function and optimisations
> were disabled. The fix[1] was to change the function signature so that
> it's arguments were explicitly const. I don't know enough about gcc to
> tell if that behaviour is arch specific or not, but it's worth trying.
>A
> Oliver
>A
> [1] https://lists.ozlabs.org/pipermail/skiboot/2016-July/004061.html
Yes, the way I solved the issue was to look at the RTL and provide
hints to the compiler that the passed argument was a constant and it
needed to be passed as such to the instruction
I would suggest just looking at the RTL and figuring out why the constraints
break
Balbir Singh.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-08-03 5:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 21:04 [memcg:auto-latest 238/243] include/linux/compiler-gcc.h:243:38: error: impossible constraint in 'asm' kbuild test robot
2016-07-31 12:11 ` Michal Hocko
2016-08-01 11:09 ` Michal Hocko
2016-08-01 11:27 ` Martin Liška
2016-08-01 12:41 ` oliver
2016-08-03 5:17 ` Balbir Singh [this message]
2016-08-02 15:18 ` Jason Baron
2016-08-01 15:00 ` Jason Baron
2016-08-01 15:29 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470201421.5034.1.camel@gmail.com \
--to=bsingharora@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=jbaron@akamai.com \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=mliska@suse.cz \
--cc=oohall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.