From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757859AbcHCMXz (ORCPT ); Wed, 3 Aug 2016 08:23:55 -0400 Received: from mx2.suse.de ([195.135.220.15]:35188 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755690AbcHCMXy (ORCPT ); Wed, 3 Aug 2016 08:23:54 -0400 Message-ID: <1470213052.4612.1.camel@suse.com> Subject: Re: [PATCH 0984/1285] Replace numeric parameter like 0444 with macro From: Oliver Neukum To: Felipe Balbi Cc: gregkh@linuxfoundation.org, k.kozlowski@samsung.com, kyungmin.park@samsung.com, m.chehab@samsung.com, m.szyprowski@samsung.com, peter.chen@freescale.com, deepa.kernel@gmail.com, baolex.ni@intel.com, chuansheng.liu@intel.com, mathias.nyman@linux.intel.com, mina86@mina86.com, stern@rowland.harvard.edu, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Date: Wed, 03 Aug 2016 10:30:52 +0200 In-Reply-To: <87bn1bqns8.fsf@linux.intel.com> References: <20160802120521.15675-1-baolex.ni@intel.com> <87bn1bqns8.fsf@linux.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-08-02 at 16:54 +0300, Felipe Balbi wrote: > Baole Ni writes: > > > I find that the developers often just specified the numeric value > > when calling a macro which is defined with a parameter for access permission. > > As we know, these numeric value for access permission have had the corresponding macro, > > and that using macro can improve the robustness and readability of the code, > > thus, I suggest replacing the numeric parameter with the macro. > > > > Signed-off-by: Chuansheng Liu > > Signed-off-by: Baole Ni > > --- > > drivers/usb/misc/usbtest.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c > > index 6b978f0..5e81dc3 100644 > > --- a/drivers/usb/misc/usbtest.c > > +++ b/drivers/usb/misc/usbtest.c > > @@ -15,7 +15,7 @@ > > /*-------------------------------------------------------------------------*/ > > > > static int override_alt = -1; > > -module_param_named(alt, override_alt, int, 0644); > > +module_param_named(alt, override_alt, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > > line too long. You need to run this series through scripts/checkpatch.pl > Before we think about that, the basic question whether S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH is clearer and easier to read than 0644 must be decided. I would saz no, it is not. Regards Oliver