From: Johannes Berg <johannes@sipsolutions.net>
To: Maxim Altshul <maxim.altshul@ti.com>, linux-kernel@vger.kernel.org
Cc: john.stultz@linaro.org, Kalle Valo <kvalo@codeaurora.org>,
Eliad Peller <eliad@wizery.com>, Yaniv Machani <yanivma@ti.com>
Subject: Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput
Date: Fri, 05 Aug 2016 14:22:42 +0200 [thread overview]
Message-ID: <1470399762.2977.40.camel@sipsolutions.net> (raw)
In-Reply-To: <20160804124314.7636-2-maxim.altshul@ti.com>
On Thu, 2016-08-04 at 15:43 +0300, Maxim Altshul wrote:
> - The variable is added to allow the driver an easy access
> to it's own hw->priv when the op is invoked.
>
> - Change wlcore op accordingly.
>
I'm applying this now, with a big BUT:
1) your changelog is crap - I've rewritten it to indicate what's going
on
2) I think the change makes sense, but as far as fixing the bug is
concerned it's actually completely stupid
3) I expect you to submit a proper bugfix for mac80211 ASAP, to not
call into the driver before the station is actually known to the
driver.
johannes
next prev parent reply other threads:[~2016-08-05 12:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 12:43 [PATCH 0/2] get_expected_throughput interface update Maxim Altshul
2016-08-04 12:43 ` [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput Maxim Altshul
2016-08-04 12:43 ` [PATCH 2/2] wlcore: Remove wl pointer from wl_sta structure Maxim Altshul
2016-08-04 21:31 ` John Stultz
2016-08-15 7:56 ` Kalle Valo
2016-08-15 7:56 ` Kalle Valo
2016-08-04 21:31 ` [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput John Stultz
2016-08-05 5:40 ` Johannes Berg
2016-08-05 6:03 ` John Stultz
2016-08-05 12:22 ` Johannes Berg [this message]
2016-08-05 12:24 ` Johannes Berg
2016-08-05 13:25 ` Altshul, Maxim
2016-08-05 15:34 ` Johannes Berg
2016-08-07 13:42 ` Altshul, Maxim
2016-08-08 6:10 ` Johannes Berg
2016-08-08 10:42 ` Altshul, Maxim
2016-08-09 7:58 ` Johannes Berg
2016-08-10 8:03 ` Altshul, Maxim
2016-08-15 7:59 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470399762.2977.40.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=eliad@wizery.com \
--cc=john.stultz@linaro.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxim.altshul@ti.com \
--cc=yanivma@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.