From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751976AbcHGQSg (ORCPT ); Sun, 7 Aug 2016 12:18:36 -0400 Received: from smtprelay0246.hostedemail.com ([216.40.44.246]:55963 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751693AbcHGQSf (ORCPT ); Sun, 7 Aug 2016 12:18:35 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,3,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:967:968:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2504:2525:2553:2560:2563:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6119:7775:7903:8660:9025:10004:10400:10848:10967:11232:11658:11914:12043:12517:12519:12740:13069:13148:13230:13311:13357:13439:14096:14097:14180:14181:14659:14721:21060:21080:21433:30012:30054:30062:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: alley87_67c22f8513e00 X-Filterd-Recvd-Size: 1884 Message-ID: <1470586711.28648.38.camel@perches.com> Subject: Re: [PATCH] scripts/Lindent: clean up and optimize From: Joe Perches To: Jean Delvare Cc: LKML , Andrew Morton Date: Sun, 07 Aug 2016 09:18:31 -0700 In-Reply-To: <20160807174849.1e30bef7@endymion> References: <20160805112618.6c43997f@endymion> <1470419599.28648.7.camel@perches.com> <20160807174849.1e30bef7@endymion> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-08-07 at 17:48 +0200, Jean Delvare wrote: > Hi Joe, > > On Fri, 05 Aug 2016 10:53:19 -0700, Joe Perches wrote: > > > > On Fri, 2016-08-05 at 11:26 +0200, Jean Delvare wrote: > > > > > > * Add a few blank lines to improve readability. > > > * Don't call cut 3 times when once is enough. > > > * Drop a useless semicolon. > > As it commonly reflows > 80 column code very badly, > > my preference would be to remove Lindent instead. > > > > https://lkml.org/lkml/2013/2/11/390 > This was 3.5 years ago, so apparently it's not happening. > > Why don't you just remove -l80 from the options, if this is your only > concern with the script? line length is not context aware and you'd get > 256 column lines in a lot of cases. > Adding the appropriate option to indent to > support what we think is good would seem even better, but I do not have > any time to devote to this task. Nor does anyone else. indent has had 1 change in 14 years. clang-format might be a better tool and a better suggestion than Lindent now.