Re: [PATCH] BB_NO_NETWORK: Fallback to local source for git lsremote

[Tobias Hagelborn <tobias.hagelborn@axis.com>]

Hi Richard,

I think I understand your concern. This patch takes whatever is available locally and that means it is a side-effect compared to not setting BB_NO_NETWORK. Something the user might not expect.

I don't know if you would accept the use of a new  flag that the user can set to agree with this side effect.

Something along the lines of "FORCE_LOCAL_TAGS". 
Then the user would have given some consent on that side-affect.
We think it is still very useful to us to be able to build locally with whatever you have fetched in cases where no NW is available and you basically know that few/no tags have moved.


Regards
Tobias


________________________________________
From: Richard Purdie <richard.purdie@linuxfoundation.org>
Sent: Monday, August 8, 2016 11:55 AM
To: Tobias Hagelborn; bitbake-devel@lists.openembedded.org
Subject: Re: [bitbake-devel] [PATCH] BB_NO_NETWORK: Fallback to local source for git lsremote

On Mon, 2016-08-08 at 08:34 +0000, Tobias Hagelborn wrote:
> Change made to enable building offline also with git tag references
> in SRC_URI.
>
> If BB_NO_NETWORK is set, fallback to search for tags and revisions
> in local DL_DIR / GITDIR in order to avoid network access.

I'm not sure I agree with this since you'd get different build results
depending on whether BB_NO_NETWORK is set or not.

I think if BB_NO_NETWORK is set, its reasonable to assume that the
configuration should be locked down and that BB_NO_NETWORK should not
have other side effects like this.

It would also make it very hard to detect unlocked configurations
during testing which currently are quite easily identified.

Cheers,

Richard