Re: [PATCH] drm: Make sure drm_vblank_no_hw_counter isn't abused

From: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
To: "dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>
Cc: "Vetter, Daniel" <daniel.vetter@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm: Make sure drm_vblank_no_hw_counter isn't abused
Date: Mon, 8 Aug 2016 16:27:34 +0000	[thread overview]
Message-ID: <1470673661.5637.149.camel@intel.com> (raw)
In-Reply-To: <1470673493-14304-1-git-send-email-daniel.vetter@ffwll.ch>

Reviewed-by: Rodrigo Vivi <rdorigo.vivi@intel.com>

On Mon, 2016-08-08 at 18:24 +0200, Daniel Vetter wrote:
> Shouldn't be possible since everyone kzallocs this, but better safe
> than sorry. Random drive-by-idea really.
> 
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  drivers/gpu/drm/drm_irq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
> index f5a9f8cef360..10611a936059 100644
> --- a/drivers/gpu/drm/drm_irq.c
> +++ b/drivers/gpu/drm/drm_irq.c
> @@ -1795,6 +1795,7 @@ EXPORT_SYMBOL(drm_crtc_handle_vblank);
>   */
>  u32 drm_vblank_no_hw_counter(struct drm_device *dev, unsigned int
> pipe)
>  {
> +	WARN_ON_ONCE(dev->max_vblank_count != 0);
>  	return 0;
>  }
>  EXPORT_SYMBOL(drm_vblank_no_hw_counter);
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx