All of lore.kernel.org
 help / color / mirror / Atom feed
From: james_p_freyensee@linux.intel.com (J Freyensee)
Subject: [PATCH RFC] nvmet-rdma: +1 to *queue_size from hsqsize/hrqsize
Date: Mon, 08 Aug 2016 10:48:17 -0700	[thread overview]
Message-ID: <1470678497.2626.2.camel@linux.intel.com> (raw)
In-Reply-To: <1470672588.40000.22.camel@intel.com>

On Mon, 2016-08-08@16:09 +0000, Verkamp, Daniel wrote:
> Hi Jay,
> 
> On Fri, 2016-08-05@20:00 -0700, Jay Freyensee wrote:
> > 
> > -	queue->recv_queue_size = le16_to_cpu(req->hsqsize);
> > -	queue->send_queue_size = le16_to_cpu(req->hrqsize);
> > +	queue->recv_queue_size = le16_to_cpu(req->hsqsize)+1;
> > +	queue->send_queue_size = le16_to_cpu(req->hrqsize)+1;
> 
> I think the +1 needs to be inside the le16_to_cpu() in both cases.

Thanks.

This patch will be dependent on the "nvme-rdma: sqsize/hsqsize/hrqsize
is 0-based val" patch, which reading the spec again I still think it's
0-based.

> 
> -- Daniel

      reply	other threads:[~2016-08-08 17:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-06  3:00 [PATCH RFC] nvmet-rdma: +1 to *queue_size from hsqsize/hrqsize Jay Freyensee
2016-08-08 16:09 ` Verkamp, Daniel
2016-08-08 17:48   ` J Freyensee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470678497.2626.2.camel@linux.intel.com \
    --to=james_p_freyensee@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.