From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: drivers/pinctrl/intel/pinctrl-merrifield.c:518:10: error: implicit declaration of function 'readl'
Date: Tue, 09 Aug 2016 18:51:40 +0300 [thread overview]
Message-ID: <1470757900.25395.10.camel@linux.intel.com> (raw)
In-Reply-To: <201608080913.KscFPUG3%fengguang.wu@intel.com>
On Mon, 2016-08-08 at 09:41 +0800, kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux
> .git master
> head: 29b4817d4018df78086157ea3a55c1d9424a7cfc
> commit: 4e80c8f505741cbdef3e10862ea36057e8d85e7c pinctrl: intel: Add
> Intel Merrifield pin controller support
> date: 6 weeks ago
> config: x86_64-randconfig-x012-201632 (attached as .config)
> compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
> git checkout 4e80c8f505741cbdef3e10862ea36057e8d85e7c
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
Patch was sent quite before this report has been generated.
https://patchwork.ozlabs.org/patch/654916/
>
> drivers/pinctrl/intel/pinctrl-merrifield.c: In function
> 'mrfld_pin_dbg_show':
> > > drivers/pinctrl/intel/pinctrl-merrifield.c:518:10: error: implicit
> > > declaration of function 'readl' [-Werror=implicit-function-
> > > declaration]
> value = readl(bufcfg);
> ^~~~~
> drivers/pinctrl/intel/pinctrl-merrifield.c: In function
> 'mrfld_update_bufcfg':
> > > drivers/pinctrl/intel/pinctrl-merrifield.c:575:2: error: implicit
> > > declaration of function 'writel' [-Werror=implicit-function-
> > > declaration]
> writel(value, bufcfg);
> ^~~~~~
> cc1: some warnings being treated as errors
>
> vim +/readl +518 drivers/pinctrl/intel/pinctrl-merrifield.c
>
> 512 if (!mrfld_buf_available(mp, pin)) {
> 513 seq_puts(s, "not available");
> 514 return;
> 515 }
> 516
> 517 bufcfg = mrfld_get_bufcfg(mp, pin);
> > 518 value = readl(bufcfg);
> 519
> 520 mode = (value & BUFCFG_PINMODE_MASK) >>
> BUFCFG_PINMODE_SHIFT;
> 521 if (!mode)
> 522 seq_puts(s, "GPIO ");
> 523 else
> 524 seq_printf(s, "mode %d ", mode);
> 525
> 526 seq_printf(s, "0x%08x", value);
> 527 }
> 528
> 529 static const struct pinctrl_ops mrfld_pinctrl_ops = {
> 530 .get_groups_count = mrfld_get_groups_count,
> 531 .get_group_name = mrfld_get_group_name,
> 532 .get_group_pins = mrfld_get_group_pins,
> 533 .pin_dbg_show = mrfld_pin_dbg_show,
> 534 };
> 535
> 536 static int mrfld_get_functions_count(struct pinctrl_dev
> *pctldev)
> 537 {
> 538 struct mrfld_pinctrl *mp =
> pinctrl_dev_get_drvdata(pctldev);
> 539
> 540 return mp->nfunctions;
> 541 }
> 542
> 543 static const char *mrfld_get_function_name(struct
> pinctrl_dev *pctldev,
> 544 unsigned int
> function)
> 545 {
> 546 struct mrfld_pinctrl *mp =
> pinctrl_dev_get_drvdata(pctldev);
> 547
> 548 return mp->functions[function].name;
> 549 }
> 550
> 551 static int mrfld_get_function_groups(struct pinctrl_dev
> *pctldev,
> 552 unsigned int
> function,
> 553 const char * const
> **groups,
> 554 unsigned int *
> const ngroups)
> 555 {
> 556 struct mrfld_pinctrl *mp =
> pinctrl_dev_get_drvdata(pctldev);
> 557
> 558 *groups = mp->functions[function].groups;
> 559 *ngroups = mp->functions[function].ngroups;
> 560 return 0;
> 561 }
> 562
> 563 static void mrfld_update_bufcfg(struct mrfld_pinctrl
> *mp, unsigned int pin,
> 564 u32 bits, u32 mask)
> 565 {
> 566 void __iomem *bufcfg;
> 567 u32 value;
> 568
> 569 bufcfg = mrfld_get_bufcfg(mp, pin);
> 570 value = readl(bufcfg);
> 571
> 572 value &= ~mask;
> 573 value |= bits & mask;
> 574
> > 575 writel(value, bufcfg);
> 576 }
> 577
> 578 static int mrfld_pinmux_set_mux(struct pinctrl_dev
> *pctldev,
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology
> Center
> https://lists.01.org/pipermail/kbuild-all Intel
> Corporation
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2016-08-09 15:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 1:41 drivers/pinctrl/intel/pinctrl-merrifield.c:518:10: error: implicit declaration of function 'readl' kbuild test robot
2016-08-09 15:51 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470757900.25395.10.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.