Re: [oe-commits] [openembedded-core] 01/51: piglit: fix build failure with gold linker

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2016-08-10 at 11:59 +0200, Martin Jansa wrote:
> On Wed, Aug 10, 2016 at 09:47:26AM +0000, git@git.openembedded.org wr
> ote:
> > rpurdie pushed a commit to branch master
> > in repository openembedded-core.
> > 
> > commit 79005ff905f8c82a8766af5a927b9a0f8929e24f
> > Author: Maxin B. John <maxin.john@intel.com>
> > AuthorDate: Mon Aug 1 18:34:49 2016 +0300
> > 
> >     piglit: fix build failure with gold linker
> >     
> >     When we use gold linker while DISTRO set to "nodistro", piglit
> > build
> >     fails with the following error:
> >     
> >     | ../../../../lib/libpiglitutil_gl.so.0: error: undefined
> > reference to
> >     'dlsym'
> >     | ../../../../lib/libpiglitutil_gl.so.0: error: undefined
> > reference to
> >     'dlerror'
> >     | ../../../../lib/libpiglitutil_gl.so.0: error: undefined
> > reference to
> >     'dlopen'
> >     | collect2: error: ld returned 1 exit status
> >     
> >     Fix it by providing '-ldl' to LDFLAGS.
> >     
> >     [YOCTO #9851]
> >     
> >     Signed-off-by: Maxin B. John <maxin.john@intel.com>
> >     Signed-off-by: Ross Burton <ross.burton@intel.com>
> > ---
> >  meta/recipes-graphics/piglit/piglit_git.bb | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/meta/recipes-graphics/piglit/piglit_git.bb
> > b/meta/recipes-graphics/piglit/piglit_git.bb
> > index 811f7af..df90c4d 100644
> > --- a/meta/recipes-graphics/piglit/piglit_git.bb
> > +++ b/meta/recipes-graphics/piglit/piglit_git.bb
> > @@ -30,6 +30,8 @@ do_compile[dirs] =+ "${B}/temp/"
> >  PACKAGECONFIG ??= ""
> >  PACKAGECONFIG[freeglut] = "-DPIGLIT_USE_GLUT=1,
> > -DPIGLIT_USE_GLUT=0,freeglut,"
> >  
> > +LDFLAGS_append = " ${@bb.utils.contains('DISTRO_FEATURES', 'ld-is
> > -gold', '-ldl', '', d)}"
> 
> There was request to fix it properly in piglit code, why was this
> version merged instead?

Accidentally. It made it into mut and I'd assumed this was a v2. Sadly
I don't keep all patch context in my head. I can revert it.

Cheers,

Richard