All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xose Vazquez Perez <xose.vazquez@gmail.com>
Cc: "Kiyoshi Ueda" <k-ueda@ct.jp.nec.com>,
	"Xose Vazquez Perez" <xose.vazquez@gmail.com>,
	"device-mapper development" <dm-devel@redhat.com>,
	"Mike Christie" <mchristi@redhat.com>,
	"Jun’ichi Nomura" <j-nomura@ce.jp.nec.com>
Subject: [PATCH 10/15] multipath-tools: delete .minio from hwtable
Date: Wed, 10 Aug 2016 18:20:33 +0200	[thread overview]
Message-ID: <1470846038-6590-10-git-send-email-xose.vazquez@gmail.com> (raw)
In-Reply-To: <1470846038-6590-1-git-send-email-xose.vazquez@gmail.com>

It's useless, default path_selector is service-time.
And document some aspects of round-robin.

Cc: Kiyoshi Ueda <k-ueda@ct.jp.nec.com>
Cc: Jun’ichi Nomura <j-nomura@ce.jp.nec.com>
Cc: Mike Christie <mchristi@redhat.com>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Benjamin Marzinski <bmarzins@redhat.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c     | 14 --------------
 multipath/multipath.conf.5 | 20 ++++++++++++--------
 2 files changed, 12 insertions(+), 22 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index cc0cfd4..3917d25 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -76,7 +76,6 @@ static struct hwentry default_hw[] = {
 		.pgpolicy      = GROUP_BY_PRIO,
 		.pgfailback    = FAILBACK_UNDEF,
 		.no_path_retry = 12,
-		.minio         = 100,
 		.checker_name  = HP_SW,
 		.prio_name     = PRIO_HP_SW,
 	},
@@ -87,7 +86,6 @@ static struct hwentry default_hw[] = {
 		.pgpolicy      = GROUP_BY_PRIO,
 		.pgfailback    = -FAILBACK_IMMEDIATE,
 		.no_path_retry = 12,
-		.minio         = 100,
 		.prio_name     = PRIO_ALUA,
 	},
 	{
@@ -97,7 +95,6 @@ static struct hwentry default_hw[] = {
 		.pgpolicy      = GROUP_BY_PRIO,
 		.pgfailback    = -FAILBACK_IMMEDIATE,
 		.no_path_retry = 12,
-		.minio         = 100,
 		.prio_name     = PRIO_ALUA,
 	},
 	{
@@ -107,7 +104,6 @@ static struct hwentry default_hw[] = {
 		.pgpolicy      = MULTIBUS,
 		.pgfailback    = FAILBACK_UNDEF,
 		.no_path_retry = 18,
-		.minio         = 100,
 	},
 	{
 		/* MSA2000 family with new firmware */
@@ -116,7 +112,6 @@ static struct hwentry default_hw[] = {
 		.pgpolicy      = GROUP_BY_PRIO,
 		.pgfailback    = -FAILBACK_IMMEDIATE,
 		.no_path_retry = 18,
-		.minio         = 100,
 		.prio_name     = PRIO_ALUA,
 	},
 	{
@@ -126,7 +121,6 @@ static struct hwentry default_hw[] = {
 		.pgpolicy      = GROUP_BY_PRIO,
 		.pgfailback    = -FAILBACK_IMMEDIATE,
 		.no_path_retry = 18,
-		.minio         = 100,
 		.prio_name     = PRIO_ALUA,
 	},
 	{
@@ -137,7 +131,6 @@ static struct hwentry default_hw[] = {
 		.pgpolicy      = GROUP_BY_PRIO,
 		.pgfailback    = -FAILBACK_IMMEDIATE,
 		.no_path_retry = 12,
-		.minio         = 100,
 		.prio_name     = PRIO_ALUA,
 	},
 	{
@@ -155,7 +148,6 @@ static struct hwentry default_hw[] = {
 		.pgpolicy      = GROUP_BY_PRIO,
 		.pgfailback    = -FAILBACK_IMMEDIATE,
 		.no_path_retry = 18,
-		.minio         = 100,
 		.prio_name     = PRIO_ALUA,
 	},
 	/*
@@ -516,7 +508,6 @@ static struct hwentry default_hw[] = {
 		.pgpolicy      = GROUP_BY_PRIO,
 		.pgfailback    = -FAILBACK_IMMEDIATE,
 		.no_path_retry = NO_PATH_RETRY_QUEUE,
-		.minio         = 100,
 		.prio_name     = PRIO_ALUA,
 	},
 	{
@@ -526,7 +517,6 @@ static struct hwentry default_hw[] = {
 		.features      = "1 queue_if_no_path",
 		.pgpolicy      = MULTIBUS,
 		.pgfailback    = 15,
-		.minio         = 15,
 	},
 		/*
 		 * IBM Power Virtual SCSI Devices
@@ -573,7 +563,6 @@ static struct hwentry default_hw[] = {
 		.pgpolicy      = GROUP_BY_PRIO,
 		.pgfailback    = -FAILBACK_IMMEDIATE,
 		.flush_on_last_del = FLUSH_ENABLED,
-		.minio         = 128,
 		.dev_loss      = MAX_DEV_LOSS_TMO,
 		.prio_name     = PRIO_ONTAP,
 	},
@@ -608,7 +597,6 @@ static struct hwentry default_hw[] = {
 		.pgpolicy      = GROUP_BY_SERIAL,
 		.pgfailback    = FAILBACK_UNDEF,
 		.no_path_retry = 30,
-		.minio         = 128,
 	},
 	/*
 	 * SGI
@@ -772,7 +760,6 @@ static struct hwentry default_hw[] = {
 		.features      = "1 queue_if_no_path",
 		.pgpolicy      = MULTIBUS,
 		.pgfailback    = FAILBACK_UNDEF,
-		.minio         = 100,
 	},
 	/*
 	 * Intel
@@ -796,7 +783,6 @@ static struct hwentry default_hw[] = {
 		.pgpolicy      = GROUP_BY_PRIO,
 		.pgfailback    = -FAILBACK_IMMEDIATE,
 		.no_path_retry = 12,
-		.minio         = 100,
 		.prio_name     = PRIO_ALUA,
 	},
 	/*
diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
index b34a320..4602f31 100644
--- a/multipath/multipath.conf.5
+++ b/multipath/multipath.conf.5
@@ -7,7 +7,7 @@
 .\"
 .\" ----------------------------------------------------------------------------
 .
-.TH MULTIPATH.CONF 5 2016-08-07 "Linux"
+.TH MULTIPATH.CONF 5 2016-08-09 "Linux"
 .
 .
 .\" ----------------------------------------------------------------------------
@@ -162,7 +162,8 @@ kernel multipath target. There are three selector algorithms:
 .TP 12
 .I "round-robin 0"
 Loop through every path in the path group, sending the same amount of IO to
-each.
+each. Some aspects of behavior can be controlled with the attributes:
+\fIrr_min_io\fR, \fIrr_min_io_rq\fR and \fIrr_weight\fR.
 .TP
 .I "queue-length 0"
 Send the next bunch of IO down the path with the least amount of outstanding IO.
@@ -431,8 +432,9 @@ Default value is: \fBmanual\fR
 .
 .TP
 .B  rr_min_io
-The number of IO to route to a path before switching to the next in
-the same path group. This is only for BIO based multipath.
+Number of IO requests to route to a path before switching to the next in the
+same path group. This is only for \fIBlock I/O\fR(BIO) based multipath and 
+only apply to \fIround-robin\fR path_selector.
 .RS
 .TP
 Default value is: \fB1000\fR
@@ -441,8 +443,9 @@ Default value is: \fB1000\fR
 .
 .TP
 .B rr_min_io_rq
-The number of IO requests to route to a path before switching to the
-next in the same path group. This is only for request based multipath.
+Number of IO requests to route to a path before switching to the next in the
+same path group. This is only for \fIRequest\fR based multipath and
+only apply to \fIround-robin\fR path_selector.
 .RS
 .TP
 Default value is: \fB1\fR
@@ -465,11 +468,12 @@ Default value is: \fBmax\fR
 .
 .TP
 .B rr_weight
-If set to \fIpriorities\fR the multipath configurator will assign
-path weights as "path prio * rr_min_io". Possible values are
+If set to \fIpriorities\fR the multipath configurator will assign path weights
+as "path prio * rr_min_io". Possible values are
 .I priorities
 or
 .I uniform .
+Only apply to \fIround-robin\fR path_selector.
 .RS
 .TP
 Default value is: \fBuniform\fR
-- 
2.7.4

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

  parent reply	other threads:[~2016-08-10 16:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-10 16:20 [PATCH 01/15] multipath-tools: identify more devices at hwtable Xose Vazquez Perez
2016-08-10 16:20 ` [PATCH 02/15] multipath-tools: remove pgpolicy=FAILOVER from Ceph/RBD Xose Vazquez Perez
2016-08-10 16:51   ` Mike Christie
2016-08-10 16:20 ` [PATCH 03/15] multipath-tools: replace (|) with [] when there is one element Xose Vazquez Perez
2016-08-10 16:20 ` [PATCH 04/15] multipath-tools: replace spaces with a regex in IBM/"3303 NVDISK" Xose Vazquez Perez
2016-08-10 16:20 ` [PATCH 05/15] multipath-tools: replace "." for real values in (COMPAQ|HP)/"(MSA|HSV)1.0" Xose Vazquez Perez
2016-08-10 16:20 ` [PATCH 06/15] multipath-tools: SGI/TP9300 is a RDAC array Xose Vazquez Perez
2016-08-10 16:20 ` [PATCH 07/15] multipath-tools: add Oracle FS to hwtable Xose Vazquez Perez
2016-08-10 16:20 ` [PATCH 08/15] multipath-tools: remove blank line at multipath.conf.5 Xose Vazquez Perez
2016-08-10 16:20 ` [PATCH 09/15] multipath-tools: standardize all RDAC devices Xose Vazquez Perez
2016-08-10 16:20 ` Xose Vazquez Perez [this message]
2016-08-10 16:20 ` [PATCH 11/15] multipath-tools: add IBM/1813 - DCS3860 to hwtable Xose Vazquez Perez
2016-08-10 16:20 ` [PATCH 12/15] multipath-tools: remove patchwork reference Xose Vazquez Perez
2016-08-10 16:20 ` [PATCH 13/15] multipath-tools: document vendor, product, revision and bl_product are POSIX Extended regex Xose Vazquez Perez
2016-08-10 16:20 ` [PATCH 14/15] multipath-tools: replace queue-length by default selector Xose Vazquez Perez
2016-08-11  5:58   ` Hannes Reinecke
2016-08-11  6:52     ` Christophe Varoqui
2016-08-11 16:16     ` Xose Vazquez Perez
2016-08-10 16:20 ` [PATCH 15/15] multipath-tools: document the relation between queue_if_no_path and no_path_retry Xose Vazquez Perez
2016-08-16  7:51 ` [PATCH 01/15] multipath-tools: identify more devices at hwtable Christophe Varoqui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470846038-6590-10-git-send-email-xose.vazquez@gmail.com \
    --to=xose.vazquez@gmail.com \
    --cc=dm-devel@redhat.com \
    --cc=j-nomura@ce.jp.nec.com \
    --cc=k-ueda@ct.jp.nec.com \
    --cc=mchristi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.