From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Mayer Subject: [PATCH v5 2/7] drm/nouveau/core: make use of new strlcpytolower() function Date: Wed, 10 Aug 2016 14:04:52 -0700 Message-ID: <1470863097-21138-3-git-send-email-mmayer@broadcom.com> References: <1470863097-21138-1-git-send-email-mmayer@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1470863097-21138-1-git-send-email-mmayer-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Ben Skeggs , David Airlie , Alexandre Courbot Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: nouveau.vger.kernel.org Q2FsbCBzdHJsY3B5dG9sb3dlcigpIHJhdGhlciB0aGFuIGNvcHlpbmcgdGhlIHN0cmluZyBleHBs aWNpdGx5IGFuZAp0aGVuIHdhbGtpbmcgaXQgdG8gY29udmVydCBpdCB0byBsb3dlcmNhc2UuCgpT aWduZWQtb2ZmLWJ5OiBNYXJrdXMgTWF5ZXIgPG1tYXllckBicm9hZGNvbS5jb20+Ci0tLQogZHJp dmVycy9ncHUvZHJtL25vdXZlYXUvbnZrbS9jb3JlL2Zpcm13YXJlLmMgfCA5ICstLS0tLS0tLQog MSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L252a20vY29yZS9maXJtd2FyZS5jIGIvZHJpdmVy cy9ncHUvZHJtL25vdXZlYXUvbnZrbS9jb3JlL2Zpcm13YXJlLmMKaW5kZXggMzRlY2Q0YS4uOTgy NjAxZSAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbnZrbS9jb3JlL2Zpcm13 YXJlLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbnZrbS9jb3JlL2Zpcm13YXJlLmMK QEAgLTM2LDE2ICszNiw5IEBAIG52a21fZmlybXdhcmVfZ2V0KHN0cnVjdCBudmttX2RldmljZSAq ZGV2aWNlLCBjb25zdCBjaGFyICpmd25hbWUsCiB7CiAJY2hhciBmWzY0XTsKIAljaGFyIGNuYW1l WzE2XTsKLQlpbnQgaTsKIAogCS8qIENvbnZlcnQgZGV2aWNlIG5hbWUgdG8gbG93ZXJjYXNlICov Ci0Jc3RybmNweShjbmFtZSwgZGV2aWNlLT5jaGlwLT5uYW1lLCBzaXplb2YoY25hbWUpKTsKLQlj bmFtZVtzaXplb2YoY25hbWUpIC0gMV0gPSAnXDAnOwotCWkgPSBzdHJsZW4oY25hbWUpOwotCXdo aWxlIChpKSB7Ci0JCS0taTsKLQkJY25hbWVbaV0gPSB0b2xvd2VyKGNuYW1lW2ldKTsKLQl9CisJ c3RybGNweXRvbG93ZXIoY25hbWUsIGRldmljZS0+Y2hpcC0+bmFtZSwgc2l6ZW9mKGNuYW1lKSk7 CiAKIAlzbnByaW50ZihmLCBzaXplb2YoZiksICJudmlkaWEvJXMvJXMuYmluIiwgY25hbWUsIGZ3 bmFtZSk7CiAJcmV0dXJuIHJlcXVlc3RfZmlybXdhcmUoZncsIGYsIGRldmljZS0+ZGV2KTsKLS0g CjIuNy40CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpO b3V2ZWF1IG1haWxpbmcgbGlzdApOb3V2ZWF1QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL25vdXZlYXUK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933140AbcHJVF5 (ORCPT ); Wed, 10 Aug 2016 17:05:57 -0400 Received: from mail-qk0-f169.google.com ([209.85.220.169]:35495 "EHLO mail-qk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752197AbcHJVFq (ORCPT ); Wed, 10 Aug 2016 17:05:46 -0400 From: Markus Mayer To: Ben Skeggs , David Airlie , Alexandre Courbot Cc: Markus Mayer , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 2/7] drm/nouveau/core: make use of new strlcpytolower() function Date: Wed, 10 Aug 2016 14:04:52 -0700 Message-Id: <1470863097-21138-3-git-send-email-mmayer@broadcom.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1470863097-21138-1-git-send-email-mmayer@broadcom.com> References: <1470863097-21138-1-git-send-email-mmayer@broadcom.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Call strlcpytolower() rather than copying the string explicitly and then walking it to convert it to lowercase. Signed-off-by: Markus Mayer --- drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c index 34ecd4a..982601e 100644 --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c @@ -36,16 +36,9 @@ nvkm_firmware_get(struct nvkm_device *device, const char *fwname, { char f[64]; char cname[16]; - int i; /* Convert device name to lowercase */ - strncpy(cname, device->chip->name, sizeof(cname)); - cname[sizeof(cname) - 1] = '\0'; - i = strlen(cname); - while (i) { - --i; - cname[i] = tolower(cname[i]); - } + strlcpytolower(cname, device->chip->name, sizeof(cname)); snprintf(f, sizeof(f), "nvidia/%s/%s.bin", cname, fwname); return request_firmware(fw, f, device->dev); -- 2.7.4