From: Markus Mayer <mmayer@broadcom.com>
To: Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Cc: Markus Mayer <mmayer@broadcom.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v5 7/7] power_supply: make use of new strcpytoupper() function
Date: Wed, 10 Aug 2016 14:04:57 -0700 [thread overview]
Message-ID: <1470863097-21138-8-git-send-email-mmayer@broadcom.com> (raw)
In-Reply-To: <1470863097-21138-1-git-send-email-mmayer@broadcom.com>
Call strcpytoupper() rather than walking the string explicitly to
convert it to uppercase.
Signed-off-by: Markus Mayer <mmayer@broadcom.com>
Acked-By: Sebastian Reichel <sre@kernel.org>
---
drivers/power/power_supply_sysfs.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c
index bcde8d1..f3b77a3 100644
--- a/drivers/power/power_supply_sysfs.c
+++ b/drivers/power/power_supply_sysfs.c
@@ -256,19 +256,16 @@ void power_supply_init_attrs(struct device_type *dev_type)
static char *kstruprdup(const char *str, gfp_t gfp)
{
- char *ret, *ustr;
+ char *ustr;
- ustr = ret = kmalloc(strlen(str) + 1, gfp);
+ ustr = kmalloc(strlen(str) + 1, gfp);
- if (!ret)
+ if (!ustr)
return NULL;
- while (*str)
- *ustr++ = toupper(*str++);
+ strcpytoupper(ustr, str);
- *ustr = 0;
-
- return ret;
+ return ustr;
}
int power_supply_uevent(struct device *dev, struct kobj_uevent_env *env)
--
2.7.4
prev parent reply other threads:[~2016-08-10 21:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 21:04 [PATCH v5 0/7] lib: string: add functions to case-convert strings Markus Mayer
2016-08-10 21:04 ` Markus Mayer
[not found] ` <1470863097-21138-1-git-send-email-mmayer-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-08-10 21:04 ` [PATCH v5 1/7] " Markus Mayer
2016-08-10 21:04 ` Markus Mayer
2016-08-10 21:04 ` [PATCH v5 2/7] drm/nouveau/core: make use of new strlcpytolower() function Markus Mayer
2016-08-10 21:04 ` Markus Mayer
2016-08-10 21:04 ` [PATCH v5 6/7] drm/nouveau/fifo/gk104: make use of new strcpytoupper() function Markus Mayer
2016-08-10 21:04 ` Markus Mayer
2016-08-10 21:04 ` [PATCH v5 3/7] ACPI / device_sysfs: make use of new strtolower() function Markus Mayer
2016-08-10 21:04 ` [PATCH v5 4/7] staging: speakup: replace spk_strlwr() with strlcpytolower() Markus Mayer
2016-08-21 15:11 ` Greg Kroah-Hartman
2016-08-10 21:04 ` [PATCH v5 5/7] iscsi-target: replace iscsi_initiatorname_tolower() with strtolower() Markus Mayer
2016-08-10 21:04 ` Markus Mayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470863097-21138-8-git-send-email-mmayer@broadcom.com \
--to=mmayer@broadcom.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.