All of lore.kernel.org
 help / color / mirror / Atom feed
From: james_p_freyensee@linux.intel.com (J Freyensee)
Subject: [PATCH RFC 1/4] fabrics: define admin sqsize min default, per spec
Date: Thu, 11 Aug 2016 09:33:42 -0700	[thread overview]
Message-ID: <1470933222.2796.1.camel@linux.intel.com> (raw)
In-Reply-To: <20160811150846.GA19738@lst.de>

On Thu, 2016-08-11@17:08 +0200, Christoph Hellwig wrote:
> On Thu, Aug 11, 2016@12:01:59PM +0300, Sagi Grimberg wrote:
> > 
> > it with the non-default value. I honestly don't see the reason
> > to keep it in a variable when no one is making real use
> > of it.
> > 
> > If you would have exposed it to user-space then it would make
> > better sense (although I'm not a fan of adding not very useful
> > configs to user-space).
> 
> I agree - until we have a good use case for large admin queues
> we should keep things simple.??And I'm still pissed about the idiotic
> addition of the admin queue size to the discovery records in the last
> moment.??It's entirely contrary to the disccovery service abstraction
> we build, and pointless as well.??So the more we can ignore it, the
> better.

OK, I have no problems with that. ?So #define set the admin sqsize in
nvmf_connect_admin_queue() OK?

  reply	other threads:[~2016-08-11 16:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-11  4:07 [PATCH RFC 0/4] sqsize zero-based fixes Jay Freyensee
2016-08-11  4:07 ` [PATCH RFC 1/4] fabrics: define admin sqsize min default, per spec Jay Freyensee
2016-08-11  9:01   ` Sagi Grimberg
2016-08-11 15:08     ` Christoph Hellwig
2016-08-11 16:33       ` J Freyensee [this message]
2016-08-11  4:07 ` [PATCH RFC 2/4] nvme-rdma: fix sqsize/hsqsize/hrqsize " Jay Freyensee
2016-08-11  7:03   ` Sagi Grimberg
2016-08-11 16:35     ` J Freyensee
2016-08-11 15:21   ` Christoph Hellwig
2016-08-11 16:40     ` J Freyensee
2016-08-11 23:24     ` J Freyensee
2016-08-11  4:07 ` [PATCH RFC 3/4] nvmet-rdma: +1 to *queue_size from hsqsize/hrqsize Jay Freyensee
2016-08-11  4:07 ` [PATCH RFC 4/4] nvme-loop: set sqsize to 0-based value, per spec Jay Freyensee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470933222.2796.1.camel@linux.intel.com \
    --to=james_p_freyensee@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.