From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932256AbcHKUkT (ORCPT ); Thu, 11 Aug 2016 16:40:19 -0400 Received: from smtprelay0223.hostedemail.com ([216.40.44.223]:35986 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752100AbcHKUkR (ORCPT ); Thu, 11 Aug 2016 16:40:17 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::,RULES_HIT:41:355:379:541:599:967:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2197:2199:2393:2525:2560:2563:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3653:3866:3867:3871:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4321:5007:6117:6119:7903:9025:9592:10004:10400:10848:11026:11232:11658:11783:11914:12043:12296:12438:12517:12519:12555:12740:13069:13071:13311:13357:13439:13894:14180:14181:14659:14721:21060:21080:21221:21451:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none X-HE-Tag: spoon69_21ed80278739 X-Filterd-Recvd-Size: 2046 Message-ID: <1470948013.14552.30.camel@perches.com> Subject: Re: [REGRESSION] get_maintainer: very noisy since '-f' is optional From: Joe Perches To: Wolfram Sang , linux-kernel@vger.kernel.org Date: Thu, 11 Aug 2016 13:40:13 -0700 In-Reply-To: <20160811201442.GA16719@katana> References: <20160811201442.GA16719@katana> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-08-11 at 22:14 +0200, Wolfram Sang wrote: > Hi Joe, Hi Wolfram. One of my favorite xkcd comics: https://xkcd.com/1172/ > commit 4cad35a7ca690eabf0d241062ce9e59693ec03e7 ("get_maintainer.pl: > reduce need for command-line option -f") makes my scripts very noisy. > I regularly use get_maintainer to create CC lists for patch series > generated with coccinelle. These patch series are stored outside my > Linux git repo. Now I get for every vcs_file_exists() a warning from > git-ls-files: > > fatal: /home/wsa/Kernel/string-refactor/usb_alloc_urb/patches/sound/usb/0001-ALSA-usb-caiaq-audio-don-t-print-error-when-allocati.patch: '/home/wsa/Kernel/string-refactor/usb_alloc_urb/patches/sound/usb/0001-ALSA-usb-caiaq-audio-don-t-print-error-when-allocati.patch' is outside repository > > Git version 2.8.1 here. > > Can you take care of that? Maybe this? diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 49a00d5..aed4511 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -2136,9 +2136,11 @@ sub vcs_file_exists {        my $cmd = $VCS_cmds{"file_exists_cmd"};      $cmd =~ s/(\$\w+)/$1/eeg; # interpolate $cmd - +    $cmd .= " 2>&1";      $exists = &{$VCS_cmds{"execute_cmd"}}($cmd);   +    return 0 if ($? != 0); +      return $exists;  }