All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joshua G Lock <joshua.g.lock@linux.intel.com>
To: Piotr Figiel <figiel@gmail.com>, yocto@yoctoproject.org
Subject: Re: [meta-swupd][PATCH] swupd-image: Fix files ownership if IMAGE_BASENAME is not default
Date: Fri, 12 Aug 2016 17:03:29 +0100	[thread overview]
Message-ID: <1471017809.19073.9.camel@linux.intel.com> (raw)
In-Reply-To: <1470918465-6002-1-git-send-email-figiel@gmail.com>

On Thu, 2016-08-11 at 14:27 +0200, Piotr Figiel wrote:
> From: Piotr Figiel <p.figiel@camlintechnologies.com>
> 
> In case IMAGE_BASENAME is set on image recipe level the files
> ownership on
> target rootfs is incorrect for recipes inheriting swupd-
> image.bbclass.
> Depending on the context swupd-image.bbclass used either PN (PN_BASE)
> or
> IMAGE_BASENAME when generating path to pseudo shared state directory.
> This
> seems correct only when IMAGE_BASENAME is not set as it defaults to
> PN.
> 
> This patch resolves above problem.
> 
> Addresses [YOCTO #10108].

Good catch, thanks! Patch pushed to meta-swupd master.

Joshua

> 
> Signed-off-by: Piotr Figiel <p.figiel@camlintechnologies.com>
> ---
>  classes/swupd-image.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/classes/swupd-image.bbclass b/classes/swupd-
> image.bbclass
> index 08ab3f5..ed9bd24 100644
> --- a/classes/swupd-image.bbclass
> +++ b/classes/swupd-image.bbclass
> @@ -81,7 +81,7 @@ python () {
>          # Because real image building via SWUPD_IMAGES can happen
> also after
>          # the initial "bitbake <core image>" invocation, we have to
> keep that
>          # pseudo database around and cannot delete it.
> -        pseudo_state = d.expand('${TMPDIR}/work-
> shared/${PN_BASE}/pseudo')
> +        pseudo_state = d.expand('${TMPDIR}/work-
> shared/${IMAGE_BASENAME}/pseudo')
>          d.setVar('PSEUDO_LOCALSTATEDIR', pseudo_state)
>  
>          # Non mega virtual images must depend on the mega image
> having been
> -- 
> 1.9.1
> 


      reply	other threads:[~2016-08-12 16:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-11 12:27 [meta-swupd][PATCH] swupd-image: Fix files ownership if IMAGE_BASENAME is not default Piotr Figiel
2016-08-12 16:03 ` Joshua G Lock [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1471017809.19073.9.camel@linux.intel.com \
    --to=joshua.g.lock@linux.intel.com \
    --cc=figiel@gmail.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.