From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 0/2] be2iscsi: Logging neatening Date: Sun, 14 Aug 2016 10:29:50 -0700 Message-ID: <1471195790.4075.45.camel@perches.com> References: <1471107782.3467.28.camel@perches.com> <1471191843.4075.39.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8bit Return-path: Received: from smtprelay0143.hostedemail.com ([216.40.44.143]:56736 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752356AbcHNRaj (ORCPT ); Sun, 14 Aug 2016 13:30:39 -0400 In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Bart Van Assche , Christophe JAILLET , "linux-scsi@vger.kernel.org" Cc: Jayamohan Kallickal , Ketan Mukadam , John Soni Jose , "James E.J. Bottomley" , "Martin K. Petersen" , "linux-kernel@vger.kernel.org" On Sun, 2016-08-14 at 17:09 +0000, Bart Van Assche wrote: > My primary concern is how to enable and disable log messages from user  > space. Many drivers define their own logging macros and export a bitmask  > that allows to enable and disable logging messages per category. These  > bitmask control mechanisms are annoying because figuring out what bit  > controls which message category requires a search through the driver  > source code. I'd like to see all these custom logging macros disappear  > and being replaced by a single mechanism. The "dynamic debug" mechanism  > e.g. is in my opinion much easier to use than the different custom  > logging mechanisms. Dynamic debug doesn't have a bitmask function and still requires looking through the code for lines and format strings. I think you are looking for a system wide equivalent for the ethtool/netif_ mechanism. Nothing like that exists currently. Some code uses a bitmask/and, other code uses a level/comparison. Care to propose something?