diff for duplicates of <1471226326.4052.24.camel@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 627717d..47bbdea 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -223,7 +223,7 @@ probably might as well return an error code immediately. > has > datap->nr_started += start_threads.nr_started; > -> and below just check that datap->nr_started = nr_cpus. +> and below just check that datap->nr_started == nr_cpus. nr_cpus is set during setup so it would be possible to just have the above return nr_started and then check this accumulated value against nr_cpu below. @@ -251,7 +251,7 @@ Ok > > + > > + ret = dt_for_each_cpu_node(&start_each_secondary, (void *) > > &data); -> assert(ret = 0) +> assert(ret == 0) Sounds good > > > @@ -263,7 +263,7 @@ Sounds good I think I'll change the above so that start_cpu returns the number of cpus started (we already know the total number of cpus so the struct is unnecessary), we come in with one cpu already started so I'll check -that nr_started = nr_cpu - 1. +that nr_started == nr_cpu - 1. > > > > > +} diff --git a/a/content_digest b/N1/content_digest index c85b907..b32ad95 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\020160812170750.lqd7cbjovejyhyvl@kamzik.localdomain\0" "From\0Suraj Jitindar Singh <sjitindarsingh@gmail.com>\0" "Subject\0Re: [kvm-unit-tests PATCH V2 3/4] lib/powerpc: Add function to start secondary threads\0" - "Date\0Mon, 15 Aug 2016 01:58:46 +0000\0" + "Date\0Mon, 15 Aug 2016 11:58:46 +1000\0" "To\0Andrew Jones <drjones@redhat.com>\0" "Cc\0kvm@vger.kernel.org" pbonzini@redhat.com @@ -238,7 +238,7 @@ "> has\n" "> \302\240datap->nr_started += start_threads.nr_started;\n" "> \n" - "> and below just check that datap->nr_started = nr_cpus.\n" + "> and below just check that datap->nr_started == nr_cpus.\n" "nr_cpus is set during setup so it would be possible to just have the\n" "above return nr_started and then check this accumulated value against\n" "nr_cpu below.\n" @@ -266,7 +266,7 @@ "> > +\n" "> > +\tret = dt_for_each_cpu_node(&start_each_secondary, (void *)\n" "> > &data);\n" - "> assert(ret = 0)\n" + "> assert(ret == 0)\n" "Sounds good\n" "> \n" "> > \n" @@ -278,7 +278,7 @@ "I think I'll change the above so that start_cpu returns the number of\n" "cpus started (we already know the total number of cpus so the struct is\n" "unnecessary), we come in with one cpu already started so I'll check\n" - "that nr_started = nr_cpu - 1.\n" + "that nr_started == nr_cpu - 1.\n" "> \n" "> > \n" "> > +}\n" @@ -303,4 +303,4 @@ "> > \302\240%.elf: CFLAGS += $(arch_CFLAGS)\n" Thanks for the review -abc94e49b1d7ec6a519f8dc66f6fe0063e6f2cf017883aae76c3bd5f49ae6d22 +84e575c37a89fd1ede529a150c4e540b1a289ef44b0ade283f72cbe28ff34c5d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.