From: Chunming Zhou <David1.Zhou-5C7GfCeVMHo@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Chunming Zhou <David1.Zhou-5C7GfCeVMHo@public.gmane.org>
Subject: [PATCH 03/10] drm/amdgpu: implement vm recovery function from shadow V2
Date: Mon, 15 Aug 2016 14:06:35 +0800 [thread overview]
Message-ID: <1471241202-11463-4-git-send-email-David1.Zhou@amd.com> (raw)
In-Reply-To: <1471241202-11463-1-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org>
V2:
a. check the pt/pd if evicted, no need to recover for evicted pt/pd bo.
b. return fence to caller.
Change-Id: I46783043eecbe9fc9c2ce9230be1085aca3731bd
Signed-off-by: Chunming Zhou <David1.Zhou@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 59 ++++++++++++++++++++++++++++++++++
2 files changed, 62 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
index 229bb32..50fd971 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
@@ -1010,6 +1010,9 @@ int amdgpu_vm_bo_unmap(struct amdgpu_device *adev,
uint64_t addr);
void amdgpu_vm_bo_rmv(struct amdgpu_device *adev,
struct amdgpu_bo_va *bo_va);
+int amdgpu_vm_recover_page_table_from_shadow(struct amdgpu_device *adev,
+ struct amdgpu_vm *vm,
+ struct fence **fence);
/*
* context related structures
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 2843132..915a41a 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -700,6 +700,65 @@ error_free:
return r;
}
+int amdgpu_vm_recover_page_table_from_shadow(struct amdgpu_device *adev,
+ struct amdgpu_vm *vm,
+ struct fence **fence)
+{
+ struct amdgpu_ring *ring = adev->mman.buffer_funcs_ring;
+ struct fence *f;
+ uint64_t pt_idx;
+ uint32_t domain;
+ int r;
+
+ if (!vm->page_directory->shadow)
+ return 0;
+
+ r = amdgpu_bo_reserve(vm->page_directory, false);
+ if (r)
+ return r;
+ domain = amdgpu_mem_type_to_domain(vm->page_directory->tbo.mem.mem_type);
+ /* if bo has been evicted, then no need to recover */
+ if (domain == AMDGPU_GEM_DOMAIN_VRAM) {
+ vm->page_directory->backup_shadow = AMDGPU_BO_SHADOW_TO_PARENT;
+ r = amdgpu_bo_backup_shadow(adev, ring,
+ vm->page_directory,
+ NULL, &f, true);
+ if (r) {
+ DRM_ERROR("recover page table failed!\n");
+ goto err;
+ }
+ if (fence) {
+ fence_put(*fence);
+ *fence = fence_get(f);
+ }
+ }
+ for (pt_idx = 0; pt_idx <= vm->max_pde_used; ++pt_idx) {
+ struct amdgpu_bo *bo = vm->page_tables[pt_idx].entry.robj;
+
+ if (!bo)
+ continue;
+ domain = amdgpu_mem_type_to_domain(bo->tbo.mem.mem_type);
+ /* if bo has been evicted, then no need to recover */
+ if (domain != AMDGPU_GEM_DOMAIN_VRAM)
+ continue;
+
+ bo->backup_shadow = AMDGPU_BO_SHADOW_TO_PARENT;
+ r = amdgpu_bo_backup_shadow(adev, ring, bo,
+ NULL, &f, true);
+ if (r) {
+ DRM_ERROR("recover page table failed!\n");
+ goto err;
+ if (fence) {
+ fence_put(*fence);
+ *fence = fence_get(f);
+ }
+ }
+ }
+
+err:
+ amdgpu_bo_unreserve(vm->page_directory);
+ return r;
+}
/**
* amdgpu_vm_update_ptes - make sure that page tables are valid
*
--
1.9.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2016-08-15 6:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 6:06 [PATCH 00/10] shadow page table support V4 Chunming Zhou
[not found] ` <1471241202-11463-1-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org>
2016-08-15 6:06 ` [PATCH 01/10] drm/amdgpu: add direct submision option for copy_buffer Chunming Zhou
2016-08-15 6:06 ` [PATCH 02/10] drm/amdgpu: sync bo and shadow V2 Chunming Zhou
2016-08-15 6:06 ` Chunming Zhou [this message]
2016-08-15 6:06 ` [PATCH 04/10] drm/amdgpu: update pd shadow while updating pd Chunming Zhou
2016-08-15 6:06 ` [PATCH 05/10] drm/amdgpu: update pt shadow while updating pt Chunming Zhou
2016-08-15 6:06 ` [PATCH 06/10] drm/amdgpu: link all vm clients Chunming Zhou
2016-08-15 6:06 ` [PATCH 07/10] drm/amdgpu: add vm_list_lock Chunming Zhou
2016-08-15 6:06 ` [PATCH 08/10] drm/amdgpu: recover page tables after gpu reset Chunming Zhou
2016-08-15 6:06 ` [PATCH 09/10] drm/amdgpu: add need backup function Chunming Zhou
2016-08-15 6:06 ` [PATCH 10/10] drm/amdgpu: add backup condition for vm Chunming Zhou
2016-08-16 6:12 ` [PATCH 00/10] shadow page table support V4 Zhou, David(ChunMing)
[not found] ` <BY2PR12MB0632F1E417D92B9A50CD4A80B4130-K//h7OWB4q7Oa05ISQ/vsQdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-08-16 9:23 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471241202-11463-4-git-send-email-David1.Zhou@amd.com \
--to=david1.zhou-5c7gfcevmho@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.