All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <pure.logic@nexus-software.ie>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Peter Hurley <peter@hurleysoftware.com>,
	linux-serial@vger.kernel.org, Vinod Koul <vinod.koul@intel.com>,
	linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	ismo.puustinen@intel.com,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Subject: Re: [PATCH v10 10/11] serial: 8250_lpss: enable MSI for Intel Quark
Date: Mon, 15 Aug 2016 10:04:42 +0100	[thread overview]
Message-ID: <1471251882.5063.2.camel@nexus-software.ie> (raw)
In-Reply-To: <1471017716-44893-11-git-send-email-andriy.shevchenko@linux.intel.com>

On Fri, 2016-08-12 at 19:01 +0300, Andy Shevchenko wrote:
> Intel Quark SoC supports MSI for LPSS, in particular for UART. Enable
> MSI for
> Intel Quark.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/tty/serial/8250/8250_lpss.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/tty/serial/8250/8250_lpss.c
> b/drivers/tty/serial/8250/8250_lpss.c
> index cad96ee..5ac291c 100644
> --- a/drivers/tty/serial/8250/8250_lpss.c
> +++ b/drivers/tty/serial/8250/8250_lpss.c
> @@ -151,6 +151,17 @@ static int byt_serial_setup(struct lpss8250
> *lpss, struct uart_port *port)
>  	return 0;
>  }
>  
> +static int qrk_serial_setup(struct lpss8250 *lpss, struct uart_port
> *port)
> +{
> +	struct pci_dev *pdev = to_pci_dev(port->dev);
> +
> +	pci_enable_msi(pdev);
> 

Andy,

ret = pci_enable_msi(dev);
if (ret)
    return ret;

once added please add

Reviewed-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>

  reply	other threads:[~2016-08-15  9:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-12 16:01 [PATCH v10 00/11] serial: 8250: split LPSS to 8250_lpss, enable DMA on Quark Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 01/11] dmaengine: dw: keep copy of custom slave config in dwc Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 02/11] dmaengine: dw: set polarity of handshake interface Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 03/11] dmaengine: dw: override LLP support if asked in platform data Andy Shevchenko
2016-08-16 13:21   ` Eugeniy Paltsev
2016-08-16 13:21     ` Eugeniy Paltsev
2016-08-12 16:01 ` [PATCH v10 04/11] dmaengine: dw: provide probe(), remove() stubs for users Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 05/11] serial: 8250_dma: switch to new dmaengine_terminate_* API Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 06/11] serial: 8250_dma: adjust DMA address of the UART Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 07/11] serial: 8250: enable AFE on ports where FIFO is 16 bytes Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 08/11] serial: 8250_lpss: split LPSS driver to separate module Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 09/11] serial: 8250_lpss: move Quark code from PCI driver Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 10/11] serial: 8250_lpss: enable MSI for Intel Quark Andy Shevchenko
2016-08-15  9:04   ` Bryan O'Donoghue [this message]
2016-08-15  9:35     ` Andy Shevchenko
2016-08-12 16:01 ` [PATCH v10 11/11] serial: 8250_lpss: enable DMA on Intel Quark UART Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1471251882.5063.2.camel@nexus-software.ie \
    --to=pure.logic@nexus-software.ie \
    --cc=Eugeniy.Paltsev@synopsys.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=ismo.puustinen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=peter@hurleysoftware.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.