From: James Bottomley <jejb@linux.vnet.ibm.com>
To: Johannes Thumshirn <jthumshirn@suse.de>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Hannes Reinecke <hare@suse.de>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] sas: provide stub implementations for scsi_is_sas_phy and sas_get_address
Date: Mon, 15 Aug 2016 10:09:55 -0700 [thread overview]
Message-ID: <1471280995.2428.10.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <f19d5eeb5cc16ce43d3932924105e77210f1daac.1471273623.git.jthumshirn@suse.de>
On Mon, 2016-08-15 at 17:12 +0200, Johannes Thumshirn wrote:
> +static inline u64 sas_get_address(struct scsi_device *sdev)
> +{
> + return 0;
> +}
To be honest, we don't want this. We do want the code to fail to
compile if you ever use sas_get_address where you shouldn't because the
code will be incorrect at that point. If we could return an error,
fine, but we just return the address.
James
next prev parent reply other threads:[~2016-08-15 17:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 15:12 [PATCH v2 0/3] Fix panic when a SES device is attached to a hpsa logical volume Johannes Thumshirn
2016-08-15 15:12 ` [PATCH v2 1/3] sas: provide stub implementations for scsi_is_sas_phy and sas_get_address Johannes Thumshirn
2016-08-15 17:09 ` James Bottomley [this message]
2016-08-15 15:12 ` [PATCH v2 2/3] ses: use scsi_is_sas_rphy instead of is_sas_attached Johannes Thumshirn
2016-08-16 4:39 ` kbuild test robot
2016-08-16 4:39 ` kbuild test robot
2016-08-15 15:12 ` [PATCH v2 3/3] sas: remove is_sas_attached() Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471280995.2428.10.camel@linux.vnet.ibm.com \
--to=jejb@linux.vnet.ibm.com \
--cc=hare@suse.de \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.