From: Scott Wood <oss@buserror.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] common: env_nand: Ensure that we have nand_info[0] prior to use
Date: Mon, 15 Aug 2016 12:13:33 -0500 [thread overview]
Message-ID: <1471281213.25630.272.camel@buserror.net> (raw)
In-Reply-To: <1471280535-3897-1-git-send-email-trini@konsulko.com>
On Mon, 2016-08-15 at 13:02 -0400, Tom Rini wrote:
> Now that nand_info[] is an array of pointers we need to ensure that it's
> been populated prior to use.??We may for example have ENV in NAND set in
> configurations that run on boards with and without NAND (where default
> env is fine enough, such as omap3_beagle and beagleboard (NAND) vs
> beagle xM (no NAND)).
>
> Fixes: b616d9b0a708 ("nand: Embed mtd_info in struct nand_chip")
> Cc: Scott Wood <oss@buserror.net>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> Changes in v3:
> - Don't overload the blocksize check in readenv(), and now that
> ? blocksize would never be zero (this was the previous way to see that
> ? we had no NAND detected), remove that check.
> - Address the CONFIG_ENV_OFFSET_OOB case in env_relocate_spec() as this
> ? too would fail now if no NAND was detected.
>
> Changes in v2:
> - Oops, move check on the saveenv side in to erase_and_write_env
> ---
> ?common/env_nand.c | 11 +++++++----
> ?1 file changed, 7 insertions(+), 4 deletions(-)
Acked-by: Scott Wood <oss@buserror.net>
-Scott
next prev parent reply other threads:[~2016-08-15 17:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 17:02 [U-Boot] [PATCH v3] common: env_nand: Ensure that we have nand_info[0] prior to use Tom Rini
2016-08-15 17:13 ` Scott Wood [this message]
2016-08-16 1:11 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471281213.25630.272.camel@buserror.net \
--to=oss@buserror.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.