From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay0205.hostedemail.com ([216.40.44.205]:47220 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752258AbcHOWqm (ORCPT ); Mon, 15 Aug 2016 18:46:42 -0400 Message-ID: <1471301196.4075.133.camel@perches.com> Subject: Re: Building a subdirectory ignores parent subdir-ccflags From: Joe Perches Date: Mon, 15 Aug 2016 15:46:36 -0700 In-Reply-To: <57B23D16.8060405@suse.com> References: <5f9f49c1e0caeb3b9ee0656b6d922dbaf52a15b7.1471289489.git.joe@perches.com> <20160815210420.GA30864@kroah.com> <1471295658.4075.117.camel@perches.com> <1471296557.4075.127.camel@perches.com> <57B23D16.8060405@suse.com> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Michal Marek , linux-kbuild Cc: Greg Kroah-Hartman , "Yann E. MORIN" , Oleg Drokin , Andreas Dilger , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, lustre-devel@lists.lustre.org On Tue, 2016-08-16 at 00:07 +0200, Michal Marek wrote: Hi Michal. > > Perhaps making a specific directory should also walk up > > any parent directory Makefiles looking for subdir flags. > > > > Is that unreasonable?  Any suggestions? > I suggest to do make drivers/staging/lustre/. If building the lustre > subdirectories is going to be a common use case, then you can propagate > the subdir-ccflags-y assignment down to the individual Makefiles. I don't have a problem with that. Others might though for whatever reason. There are a couple other places in the tree that also use subdir-ccflags where the results of making a subdirectory would either fail or have unexpected results. Does it matter?  Not much, but it could be nicer if it's possible for parent Makefile paths to be ascended. I'm not much of a Makefile person, but perhaps you have some clues/tips/suggestions for implementation? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Mon, 15 Aug 2016 15:46:36 -0700 Subject: [lustre-devel] Building a subdirectory ignores parent subdir-ccflags In-Reply-To: <57B23D16.8060405@suse.com> References: <5f9f49c1e0caeb3b9ee0656b6d922dbaf52a15b7.1471289489.git.joe@perches.com> <20160815210420.GA30864@kroah.com> <1471295658.4075.117.camel@perches.com> <1471296557.4075.127.camel@perches.com> <57B23D16.8060405@suse.com> Message-ID: <1471301196.4075.133.camel@perches.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michal Marek , linux-kbuild Cc: Greg Kroah-Hartman , "Yann E. MORIN" , Oleg Drokin , Andreas Dilger , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, lustre-devel@lists.lustre.org On Tue, 2016-08-16 at 00:07 +0200, Michal Marek wrote: Hi Michal. > > Perhaps making a specific directory should also walk up > > any parent directory Makefiles looking for subdir flags. > > > > Is that unreasonable???Any suggestions? > I suggest to do make drivers/staging/lustre/. If building the lustre > subdirectories is going to be a common use case, then you can propagate > the subdir-ccflags-y assignment down to the individual Makefiles. I don't have a problem with that. Others might though for whatever reason. There are a couple other places in the tree that also use subdir-ccflags where the results of making a subdirectory would either fail or have unexpected results. Does it matter? ?Not much, but it could be nicer if it's possible for parent Makefile paths to be ascended. I'm not much of a Makefile person, but perhaps you have some clues/tips/suggestions for implementation?