diff for duplicates of <1471324201.2108.4.camel@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 78a058b..421ea68 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -265,7 +265,7 @@ On Mon, 2016-08-15 at 08:27 +0200, Andrew Jones wrote: > > > has > > > datap->nr_started += start_threads.nr_started; > > > -> > > and below just check that datap->nr_started = nr_cpus. +> > > and below just check that datap->nr_started == nr_cpus. > > nr_cpus is set during setup so it would be possible to just have > > the > > above return nr_started and then check this accumulated value @@ -301,7 +301,7 @@ On Mon, 2016-08-15 at 08:27 +0200, Andrew Jones wrote: > > > > + ret = dt_for_each_cpu_node(&start_each_secondary, > > > > (void *) > > > > &data); -> > > assert(ret = 0) +> > > assert(ret == 0) > > Sounds good > > > > > > @@ -317,7 +317,7 @@ On Mon, 2016-08-15 at 08:27 +0200, Andrew Jones wrote: > > cpus started (we already know the total number of cpus so the > > struct is > > unnecessary), we come in with one cpu already started so I'll check -> > that nr_started = nr_cpu - 1. +> > that nr_started == nr_cpu - 1. > I completely forgot that I wrote code setting up nr_cpus... After > reading this patch, I actually assumed I hadn't, because I didn't > recall addressing threads. So is the nr_cpus in setup correct? diff --git a/a/content_digest b/N1/content_digest index aaf4477..012b548 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -5,7 +5,7 @@ "ref\020160815062701.xe2zh77lydta5qzx@hawk.localdomain\0" "From\0Suraj Jitindar Singh <sjitindarsingh@gmail.com>\0" "Subject\0Re: [kvm-unit-tests PATCH V2 3/4] lib/powerpc: Add function to start secondary threads\0" - "Date\0Tue, 16 Aug 2016 05:10:01 +0000\0" + "Date\0Tue, 16 Aug 2016 15:10:01 +1000\0" "To\0Andrew Jones <drjones@redhat.com>\0" "Cc\0kvm@vger.kernel.org" pbonzini@redhat.com @@ -282,7 +282,7 @@ "> > > has\n" "> > > \302\240datap->nr_started += start_threads.nr_started;\n" "> > > \n" - "> > > and below just check that datap->nr_started = nr_cpus.\n" + "> > > and below just check that datap->nr_started == nr_cpus.\n" "> > nr_cpus is set during setup so it would be possible to just have\n" "> > the\n" "> > above return nr_started and then check this accumulated value\n" @@ -318,7 +318,7 @@ "> > > > +\tret = dt_for_each_cpu_node(&start_each_secondary,\n" "> > > > (void *)\n" "> > > > &data);\n" - "> > > assert(ret = 0)\n" + "> > > assert(ret == 0)\n" "> > Sounds good\n" "> > > \n" "> > > \n" @@ -334,7 +334,7 @@ "> > cpus started (we already know the total number of cpus so the\n" "> > struct is\n" "> > unnecessary), we come in with one cpu already started so I'll check\n" - "> > that nr_started = nr_cpu - 1.\n" + "> > that nr_started == nr_cpu - 1.\n" "> I completely forgot that I wrote code setting up nr_cpus... After\n" "> reading this patch, I actually assumed I hadn't, because I didn't\n" "> recall addressing threads. So is the nr_cpus in setup correct?\n" @@ -379,4 +379,4 @@ "> Thanks,\n" > drew -9b2aecf0ad3cf5f326780b2e935512a471eba9f55ac4e8f7f044cf50f74cda18 +833de8042f0d7b37991ea7e92aee0a9df8425251ae9c6b08fa4d595aae676251
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.