From: Dario Faggioli <dario.faggioli@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>
Subject: Re: [PATCH 2/2] x86/NUMA: cleanup
Date: Tue, 16 Aug 2016 12:02:14 +0200 [thread overview]
Message-ID: <1471341734.6806.7.camel@citrix.com> (raw)
In-Reply-To: <57AB306A0200007800104A8E@prv-mh.provo.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 1275 bytes --]
On Wed, 2016-08-10 at 05:47 -0600, Jan Beulich wrote:
> > On 10.08.16 at 12:35, <andrew.cooper3@citrix.com> wrote:
> > I observe that CONFIG_NUMA_EMU is also unconditionally true, which
> > offers further cleanup opportunities (albeit it probably a separate
> > patch).
> So I thought, but then wasn't sure eliminating just the conditionals
> it would actually be the right route - the alternative would be to
> instead just drop that NUMA emulation code altogether, as no-one
> should be using it.
>
Last time I tried to use it, it indeed was *not* useful at all... and
looking at it, it seems that nothing changed since then.
AFAICT, it's something imported from Linux quite a few time back, but
while Linux evolved its own NUMA_EMU support to something that may
actually be useful, ours stayed original.
So, for what the opinion of someone that tried to use it is worth, I
agree that we either also improve it (e.g., by trying syncing with the
Linux one), or kill it.
Regards,
Dairo
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-08-16 10:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 9:17 [PATCH 0/2] NUMA/x86 related adjustments Jan Beulich
2016-08-10 9:23 ` [PATCH 1/2] page-alloc/x86: don't restrict DMA heap to node 0 Jan Beulich
2016-08-10 9:58 ` Andrew Cooper
2016-08-10 10:21 ` Jan Beulich
2016-08-10 12:18 ` Andrew Cooper
2016-08-10 12:50 ` Jan Beulich
2016-08-11 10:44 ` [PATCH v2 " Jan Beulich
2016-08-11 10:45 ` Andrew Cooper
2016-08-11 9:53 ` [PATCH " Julien Grall
2016-08-11 10:05 ` Jan Beulich
2016-08-10 9:24 ` [PATCH 2/2] x86/NUMA: cleanup Jan Beulich
2016-08-10 10:35 ` Andrew Cooper
2016-08-10 11:47 ` Jan Beulich
2016-08-16 10:02 ` Dario Faggioli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471341734.6806.7.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.