From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Neukum Subject: Re: [PATCH] scsi: introduce a quirk for false cache reporting Date: Tue, 16 Aug 2016 12:28:17 +0200 Message-ID: <1471343297.26909.0.camel@suse.com> References: <1470657309-9564-1-git-send-email-oneukum@suse.com> <1471188464.4879.9.camel@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Martin K. Petersen" Cc: jejb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, usb-storage-ijkIwGHArpdIPJnuZ7Njw4oP9KaGy4wf@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-scsi@vger.kernel.org On Tue, 2016-08-16 at 00:44 -0400, Martin K. Petersen wrote: > >>>>> "Oliver" == Oliver Neukum writes: > > Oliver, > > Oliver> wce_default_on controls the default if the device provides no > Oliver> indication. The problem here is that the indication the device > Oliver> provides must be overridden, as they are false. > > Can't you just blacklist the mode select on the device in question? > > Something like: > > if (us->fflags & US_FL_ALWAYS_SYNC) { > sdev->skip_ms_page_3f = 1; > sdev->skip_ms_page_8 = 1; > sdev->wce_default_on = 1; > } > > ? Hi, this looks like a workable option. I am preparing a patch. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html