diff for duplicates of <14713455.3bE9d8ejOo@flatron> diff --git a/a/1.txt b/N1/1.txt index 44ae16c..a07dd80 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,7 +1,7 @@ Hi Vyacheslav, Tarek, On Tuesday 01 of October 2013 20:17:05 Vyacheslav Tyrtov wrote: -> From: Tarek Dakhran <t.dakhran-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> +> From: Tarek Dakhran <t.dakhran@samsung.com> > > Add initial device tree nodes for EXYNOS5410 SoC and SMDK5410 board. [snip] @@ -32,7 +32,7 @@ new platform specific ones. I know that previous Exynos SoCs do it this way, but this is no good. > + -> + dwmmc0@12200000 { +> + dwmmc0 at 12200000 { I believe there has been a patch series renaming these dwmmcX nodes to follow correct DT conventions and doing some more clean-up. IMHO you @@ -49,13 +49,13 @@ should consider basing your patch on top of that series. nit: Please separate subnodes from properties with a blank line. -> + slot@0 { +> + slot at 0 { > + reg = <0>; > + bus-width = <8>; > + }; > + }; > + -> + dwmmc1@12210000 { +> + dwmmc1 at 12210000 { > + status = "disabled"; Oh, the series I mentioned above also corrected the way the status @@ -66,7 +66,7 @@ disabled. > + }; > + -> + dwmmc2@12220000 { +> + dwmmc2 at 12220000 { > + num-slots = <1>; > + supports-highspeed; > + fifo-depth = <0x80>; @@ -77,7 +77,7 @@ disabled. nit: A blank line would be nice here. -> + slot@0 { +> + slot at 0 { > + reg = <0>; > + bus-width = <4>; > + disable-wp; @@ -114,7 +114,7 @@ nit: A blank line would be nice here. > + #address-cells = <1>; > + #size-cells = <0>; > + -> + CPU0: cpu@0 { +> + CPU0: cpu at 0 { > + device_type = "cpu"; > + compatible = "arm,cortex-a15"; > + reg = <0>; @@ -124,28 +124,28 @@ nit: A blank line would be nice here. nit: Please keep spacing between nodes. -> + CPU1: cpu@1 { +> + CPU1: cpu at 1 { > + device_type = "cpu"; > + compatible = "arm,cortex-a15"; > + reg = <1>; > + cci-control-port = <&cci_control2>; > + clock-frequency = <1600000000>; > + }; -> + CPU2: cpu@2 { +> + CPU2: cpu at 2 { > + device_type = "cpu"; > + compatible = "arm,cortex-a15"; > + reg = <2>; > + cci-control-port = <&cci_control2>; > + clock-frequency = <1600000000>; > + }; -> + CPU3: cpu@3 { +> + CPU3: cpu at 3 { > + device_type = "cpu"; > + compatible = "arm,cortex-a15"; > + reg = <3>; > + cci-control-port = <&cci_control2>; > + clock-frequency = <1600000000>; > + }; -> + CPU4: cpu@4 { +> + CPU4: cpu at 4 { The @unit-address suffix of node name must be equal to first address entry of reg property. @@ -156,21 +156,21 @@ of reg property. > + cci-control-port = <&cci_control1>; > + clock-frequency = <1200000000>; > + }; -> + CPU5: cpu@5 { +> + CPU5: cpu at 5 { > + device_type = "cpu"; > + compatible = "arm,cortex-a7"; > + reg = <0x101>; > + cci-control-port = <&cci_control1>; > + clock-frequency = <1200000000>; > + }; -> + CPU6: cpu@6 { +> + CPU6: cpu at 6 { > + device_type = "cpu"; > + compatible = "arm,cortex-a7"; > + reg = <0x102>; > + cci-control-port = <&cci_control1>; > + clock-frequency = <1200000000>; > + }; -> + CPU7: cpu@7 { +> + CPU7: cpu at 7 { > + device_type = "cpu"; > + compatible = "arm,cortex-a7"; > + reg = <0x103>; @@ -190,7 +190,7 @@ nit: Missing space before the brace. Is this a real device? Are bindings for it documented somewhere? > + -> + cci@10d20000 { +> + cci at 10d20000 { nit: Please be consistent with case of hexadecimal characters. @@ -206,26 +206,26 @@ nit: Ditto. nit: Ditto. > + -> + cci_control0: slave-if@1000 { +> + cci_control0: slave-if at 1000 { > + compatible = "arm,cci-400-ctrl-if"; > + interface-type = "ace-lite"; > + reg = <0x1000 0x1000>; > + }; > + -> + cci_control1: slave-if@4000 { +> + cci_control1: slave-if at 4000 { > + compatible = "arm,cci-400-ctrl-if"; > + interface-type = "ace"; > + reg = <0x4000 0x1000>; > + }; > + -> + cci_control2: slave-if@5000 { +> + cci_control2: slave-if at 5000 { > + compatible = "arm,cci-400-ctrl-if"; > + interface-type = "ace"; > + reg = <0x5000 0x1000>; > + }; > + }; > + -> + clock: clock-controller@10010000 { +> + clock: clock-controller at 10010000 { > + compatible = "samsung,exynos5410-clock"; > + reg = <0x10010000 0x30000>; > + #clock-cells = <1>; @@ -235,7 +235,7 @@ nit: Ditto. nit: Unnecessary extra blank line. -> + mct@101C0000 { +> + mct at 101C0000 { > + compatible = "samsung,exynos4210-mct"; > + reg = <0x101C0000 0xb00>; @@ -248,8 +248,3 @@ I don't think MCT has ever been an interrupt controller. Best regards, Tomasz - --- -To unsubscribe from this list: send the line "unsubscribe devicetree" in -the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index e65b009..1ea4475 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,36 +1,15 @@ "ref\01380644227-12244-1-git-send-email-v.tyrtov@samsung.com\0" "ref\01380644227-12244-5-git-send-email-v.tyrtov@samsung.com\0" - "ref\01380644227-12244-5-git-send-email-v.tyrtov-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org\0" - "From\0Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0" - "Subject\0Re: [PATCH 4/6] ARM: dts: Add initial device tree support for EXYNOS5410\0" + "From\0tomasz.figa@gmail.com (Tomasz Figa)\0" + "Subject\0[PATCH 4/6] ARM: dts: Add initial device tree support for EXYNOS5410\0" "Date\0Wed, 02 Oct 2013 22:54:15 +0200\0" - "To\0linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org\0" - "Cc\0Vyacheslav Tyrtov <v.tyrtov-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>" - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> - devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - Kukjin Kim <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> - Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org> - Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org> - Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org> - Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org> - Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> - linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org> - Tarek Dakhran <t.dakhran-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> - Daniel Lezcano <daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> - linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - Rob Landley <rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org> - Mike Turquette <mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> - Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> - Naour Romain <romain.naour-oid7hba3+9NWj0EZb7rXcA@public.gmane.org> - " Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Hi Vyacheslav, Tarek,\n" "\n" "On Tuesday 01 of October 2013 20:17:05 Vyacheslav Tyrtov wrote:\n" - "> From: Tarek Dakhran <t.dakhran-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>\n" + "> From: Tarek Dakhran <t.dakhran@samsung.com>\n" "> \n" "> Add initial device tree nodes for EXYNOS5410 SoC and SMDK5410 board.\n" "[snip]\n" @@ -61,7 +40,7 @@ "way, but this is no good.\n" "\n" "> +\n" - "> +\tdwmmc0@12200000 {\n" + "> +\tdwmmc0 at 12200000 {\n" "\n" "I believe there has been a patch series renaming these dwmmcX nodes to \n" "follow correct DT conventions and doing some more clean-up. IMHO you \n" @@ -78,13 +57,13 @@ "\n" "nit: Please separate subnodes from properties with a blank line.\n" "\n" - "> +\t\tslot@0 {\n" + "> +\t\tslot at 0 {\n" "> +\t\t\treg = <0>;\n" "> +\t\t\tbus-width = <8>;\n" "> +\t\t};\n" "> +\t};\n" "> +\n" - "> +\tdwmmc1@12210000 {\n" + "> +\tdwmmc1 at 12210000 {\n" "> +\t\tstatus = \"disabled\";\n" "\n" "Oh, the series I mentioned above also corrected the way the status \n" @@ -95,7 +74,7 @@ "\n" "> +\t};\n" "> +\n" - "> +\tdwmmc2@12220000 {\n" + "> +\tdwmmc2 at 12220000 {\n" "> +\t\tnum-slots = <1>;\n" "> +\t\tsupports-highspeed;\n" "> +\t\tfifo-depth = <0x80>;\n" @@ -106,7 +85,7 @@ "\n" "nit: A blank line would be nice here.\n" "\n" - "> +\t\tslot@0 {\n" + "> +\t\tslot at 0 {\n" "> +\t\t\treg = <0>;\n" "> +\t\t\tbus-width = <4>;\n" "> +\t\t\tdisable-wp;\n" @@ -143,7 +122,7 @@ "> +\t\t#address-cells = <1>;\n" "> +\t\t#size-cells = <0>;\n" "> +\n" - "> +\t\tCPU0: cpu@0 {\n" + "> +\t\tCPU0: cpu at 0 {\n" "> +\t\t\tdevice_type = \"cpu\";\n" "> +\t\t\tcompatible = \"arm,cortex-a15\";\n" "> +\t\t\treg = <0>;\n" @@ -153,28 +132,28 @@ "\n" "nit: Please keep spacing between nodes.\n" "\n" - "> +\t\tCPU1: cpu@1 {\n" + "> +\t\tCPU1: cpu at 1 {\n" "> +\t\t\tdevice_type = \"cpu\";\n" "> +\t\t\tcompatible = \"arm,cortex-a15\";\n" "> +\t\t\treg = <1>;\n" "> +\t\t\tcci-control-port = <&cci_control2>;\n" "> +\t\t\tclock-frequency = <1600000000>;\n" "> +\t\t};\n" - "> +\t\tCPU2: cpu@2 {\n" + "> +\t\tCPU2: cpu at 2 {\n" "> +\t\t\tdevice_type = \"cpu\";\n" "> +\t\t\tcompatible = \"arm,cortex-a15\";\n" "> +\t\t\treg = <2>;\n" "> +\t\t\tcci-control-port = <&cci_control2>;\n" "> +\t\t\tclock-frequency = <1600000000>;\n" "> +\t\t};\n" - "> +\t\tCPU3: cpu@3 {\n" + "> +\t\tCPU3: cpu at 3 {\n" "> +\t\t\tdevice_type = \"cpu\";\n" "> +\t\t\tcompatible = \"arm,cortex-a15\";\n" "> +\t\t\treg = <3>;\n" "> +\t\t\tcci-control-port = <&cci_control2>;\n" "> +\t\t\tclock-frequency = <1600000000>;\n" "> +\t\t};\n" - "> +\t\tCPU4: cpu@4 {\n" + "> +\t\tCPU4: cpu at 4 {\n" "\n" "The @unit-address suffix of node name must be equal to first address entry \n" "of reg property.\n" @@ -185,21 +164,21 @@ "> +\t\t\tcci-control-port = <&cci_control1>;\n" "> +\t\t\tclock-frequency = <1200000000>;\n" "> +\t\t};\n" - "> +\t\tCPU5: cpu@5 {\n" + "> +\t\tCPU5: cpu at 5 {\n" "> +\t\t\tdevice_type = \"cpu\";\n" "> +\t\t\tcompatible = \"arm,cortex-a7\";\n" "> +\t\t\treg = <0x101>;\n" "> +\t\t\tcci-control-port = <&cci_control1>;\n" "> +\t\t\tclock-frequency = <1200000000>;\n" "> +\t\t};\n" - "> +\t\tCPU6: cpu@6 {\n" + "> +\t\tCPU6: cpu at 6 {\n" "> +\t\t\tdevice_type = \"cpu\";\n" "> +\t\t\tcompatible = \"arm,cortex-a7\";\n" "> +\t\t\treg = <0x102>;\n" "> +\t\t\tcci-control-port = <&cci_control1>;\n" "> +\t\t\tclock-frequency = <1200000000>;\n" "> +\t\t};\n" - "> +\t\tCPU7: cpu@7 {\n" + "> +\t\tCPU7: cpu at 7 {\n" "> +\t\t\tdevice_type = \"cpu\";\n" "> +\t\t\tcompatible = \"arm,cortex-a7\";\n" "> +\t\t\treg = <0x103>;\n" @@ -219,7 +198,7 @@ "Is this a real device? Are bindings for it documented somewhere?\n" "\n" "> +\n" - "> +\tcci@10d20000 {\n" + "> +\tcci at 10d20000 {\n" "\n" "nit: Please be consistent with case of hexadecimal characters.\n" "\n" @@ -235,26 +214,26 @@ "nit: Ditto.\n" "\n" "> +\n" - "> +\t\tcci_control0: slave-if@1000 {\n" + "> +\t\tcci_control0: slave-if at 1000 {\n" "> +\t\t\tcompatible = \"arm,cci-400-ctrl-if\";\n" "> +\t\t\tinterface-type = \"ace-lite\";\n" "> +\t\t\treg = <0x1000 0x1000>;\n" "> +\t\t};\n" "> +\n" - "> +\t\tcci_control1: slave-if@4000 {\n" + "> +\t\tcci_control1: slave-if at 4000 {\n" "> +\t\t\tcompatible = \"arm,cci-400-ctrl-if\";\n" "> +\t\t\tinterface-type = \"ace\";\n" "> +\t\t\treg = <0x4000 0x1000>;\n" "> +\t\t};\n" "> +\n" - "> +\t\tcci_control2: slave-if@5000 {\n" + "> +\t\tcci_control2: slave-if at 5000 {\n" "> +\t\t\tcompatible = \"arm,cci-400-ctrl-if\";\n" "> +\t\t\tinterface-type = \"ace\";\n" "> +\t\t\treg = <0x5000 0x1000>;\n" "> +\t\t};\n" "> +\t};\n" "> +\n" - "> +\tclock: clock-controller@10010000 {\n" + "> +\tclock: clock-controller at 10010000 {\n" "> +\t\tcompatible = \"samsung,exynos5410-clock\";\n" "> +\t\treg = <0x10010000 0x30000>;\n" "> +\t\t#clock-cells = <1>;\n" @@ -264,7 +243,7 @@ "\n" "nit: Unnecessary extra blank line.\n" "\n" - "> +\tmct@101C0000 {\n" + "> +\tmct at 101C0000 {\n" "> +\t\tcompatible = \"samsung,exynos4210-mct\";\n" "> +\t\treg = <0x101C0000 0xb00>;\n" "\n" @@ -276,11 +255,6 @@ "I don't think MCT has ever been an interrupt controller.\n" "\n" "Best regards,\n" - "Tomasz\n" - "\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe devicetree\" in\n" - "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + Tomasz -c03908cbd900576efab22af8998462651f21a1ae43497e826d8095069b940f41 +74aedbcccc7ca91379a3b3cdf5e56aaa9647432bc08b380c1c644c4133934a4e
diff --git a/a/1.txt b/N2/1.txt index 44ae16c..ad81bf5 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,7 +1,7 @@ Hi Vyacheslav, Tarek, On Tuesday 01 of October 2013 20:17:05 Vyacheslav Tyrtov wrote: -> From: Tarek Dakhran <t.dakhran-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> +> From: Tarek Dakhran <t.dakhran@samsung.com> > > Add initial device tree nodes for EXYNOS5410 SoC and SMDK5410 board. [snip] @@ -248,8 +248,3 @@ I don't think MCT has ever been an interrupt controller. Best regards, Tomasz - --- -To unsubscribe from this list: send the line "unsubscribe devicetree" in -the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index e65b009..1764fd9 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,36 +1,35 @@ "ref\01380644227-12244-1-git-send-email-v.tyrtov@samsung.com\0" "ref\01380644227-12244-5-git-send-email-v.tyrtov@samsung.com\0" - "ref\01380644227-12244-5-git-send-email-v.tyrtov-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org\0" - "From\0Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0" + "From\0Tomasz Figa <tomasz.figa@gmail.com>\0" "Subject\0Re: [PATCH 4/6] ARM: dts: Add initial device tree support for EXYNOS5410\0" "Date\0Wed, 02 Oct 2013 22:54:15 +0200\0" - "To\0linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org\0" - "Cc\0Vyacheslav Tyrtov <v.tyrtov-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>" - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> - devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - Kukjin Kim <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> - Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org> - Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org> - Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org> - Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org> - Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> - linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org> - Tarek Dakhran <t.dakhran-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> - Daniel Lezcano <daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> - linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - Rob Landley <rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org> - Mike Turquette <mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> - Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> - Naour Romain <romain.naour-oid7hba3+9NWj0EZb7rXcA@public.gmane.org> - " Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" + "Cc\0Vyacheslav Tyrtov <v.tyrtov@samsung.com>" + linux-kernel@vger.kernel.org + Mark Rutland <mark.rutland@arm.com> + devicetree@vger.kernel.org + Kukjin Kim <kgene.kim@samsung.com> + Russell King <linux@arm.linux.org.uk> + Ben Dooks <ben-linux@fluff.org> + Pawel Moll <pawel.moll@arm.com> + Ian Campbell <ijc+devicetree@hellion.org.uk> + Stephen Warren <swarren@wwwdotorg.org> + linux-doc@vger.kernel.org + Rob Herring <rob.herring@calxeda.com> + Tarek Dakhran <t.dakhran@samsung.com> + Daniel Lezcano <daniel.lezcano@linaro.org> + linux-samsung-soc@vger.kernel.org + Rob Landley <rob@landley.net> + Mike Turquette <mturquette@linaro.org> + Thomas Gleixner <tglx@linutronix.de> + Naour Romain <romain.naour@openwide.fr> + " Heiko Stuebner <heiko@sntech.de>\0" "\00:1\0" "b\0" "Hi Vyacheslav, Tarek,\n" "\n" "On Tuesday 01 of October 2013 20:17:05 Vyacheslav Tyrtov wrote:\n" - "> From: Tarek Dakhran <t.dakhran-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>\n" + "> From: Tarek Dakhran <t.dakhran@samsung.com>\n" "> \n" "> Add initial device tree nodes for EXYNOS5410 SoC and SMDK5410 board.\n" "[snip]\n" @@ -276,11 +275,6 @@ "I don't think MCT has ever been an interrupt controller.\n" "\n" "Best regards,\n" - "Tomasz\n" - "\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe devicetree\" in\n" - "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + Tomasz -c03908cbd900576efab22af8998462651f21a1ae43497e826d8095069b940f41 +80a4c2da99b89ba01425b595c0b27759f24310aef979a198ed408a9c070cfa49
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.